From bc6cd9daafd177af9f66ae8fcd234fdba29b47a6 Mon Sep 17 00:00:00 2001
From: Maximiliano Sandoval <msandova@gnome.org>
Date: Tue, 31 Dec 2024 12:48:48 +0100
Subject: [PATCH] details_page: Use property class in action rows

---
 data/resources/ui/account_details_page.ui | 38 +++++++++--------------
 src/widgets/accounts/details.rs           | 20 ++++++------
 2 files changed, 24 insertions(+), 34 deletions(-)

diff --git a/data/resources/ui/account_details_page.ui b/data/resources/ui/account_details_page.ui
index 7b91174..88f592b 100644
--- a/data/resources/ui/account_details_page.ui
+++ b/data/resources/ui/account_details_page.ui
@@ -115,23 +115,19 @@
                             <property name="selection-mode">none</property>
                             <property name="margin-bottom">18</property>
                             <child>
-                              <object class="AdwActionRow">
+                              <object class="AdwActionRow" id="algorithm_row">
                                 <property name="title" translatable="yes">Algorithm</property>
-                                <child>
-                                  <object class="GtkLabel" id="algorithm_label">
-                                    <property name="halign">end</property>
-                                  </object>
-                                </child>
+                                <style>
+                                  <class name="property"/>
+                                </style>
                               </object>
                             </child>
                             <child>
-                              <object class="AdwActionRow">
+                              <object class="AdwActionRow" id="method_row">
                                 <property name="title" translatable="yes">Computing Method</property>
-                                <child>
-                                  <object class="GtkLabel" id="method_label">
-                                    <property name="halign">end</property>
-                                  </object>
-                                </child>
+                                <style>
+                                  <class name="property"/>
+                                </style>
                               </object>
                             </child>
                             <child>
@@ -147,22 +143,18 @@
                               <object class="AdwActionRow" id="period_row">
                                 <property name="title" translatable="yes">Period</property>
                                 <property name="subtitle" translatable="yes">Duration in seconds until the next password update</property>
-                                <child>
-                                  <object class="GtkLabel" id="period_label">
-                                    <property name="halign">end</property>
-                                  </object>
-                                </child>
+                                <style>
+                                  <class name="property"/>
+                                </style>
                               </object>
                             </child>
                             <child>
-                              <object class="AdwActionRow">
+                              <object class="AdwActionRow" id="digits_row">
                                 <property name="title" translatable="yes">Digits</property>
                                 <property name="subtitle" translatable="yes">Length of the generated code</property>
-                                <child>
-                                  <object class="GtkLabel" id="digits_label">
-                                    <property name="halign">end</property>
-                                  </object>
-                                </child>
+                                <style>
+                                  <class name="property"/>
+                                </style>
                               </object>
                             </child>
                             <child>
diff --git a/src/widgets/accounts/details.rs b/src/widgets/accounts/details.rs
index 37932b7..89865ca 100644
--- a/src/widgets/accounts/details.rs
+++ b/src/widgets/accounts/details.rs
@@ -33,15 +33,13 @@ mod imp {
         #[template_child(id = "list")]
         pub listbox: TemplateChild<gtk::ListBox>,
         #[template_child]
-        pub algorithm_label: TemplateChild<gtk::Label>,
+        pub algorithm_row: TemplateChild<adw::ActionRow>,
         #[template_child]
-        pub method_label: TemplateChild<gtk::Label>,
+        pub method_row: TemplateChild<adw::ActionRow>,
         #[template_child]
         pub counter_spinbutton: TemplateChild<adw::SpinRow>,
         #[template_child]
-        pub period_label: TemplateChild<gtk::Label>,
-        #[template_child]
-        pub digits_label: TemplateChild<gtk::Label>,
+        pub digits_row: TemplateChild<adw::ActionRow>,
         #[template_child]
         pub period_row: TemplateChild<adw::ActionRow>,
         #[template_child]
@@ -164,19 +162,19 @@ impl AccountDetailsPage {
     fn set_provider(&self, provider: Provider) {
         let imp = self.imp();
         imp.provider_entry.set_text(&provider.name());
-        imp.algorithm_label
-            .set_text(&provider.algorithm().to_locale_string());
-        imp.method_label
-            .set_text(&provider.method().to_locale_string());
+        imp.algorithm_row
+            .set_subtitle(&provider.algorithm().to_locale_string());
+        imp.method_row
+            .set_subtitle(&provider.method().to_locale_string());
         if provider.method().is_event_based() {
             imp.counter_spinbutton.set_visible(true);
             imp.period_row.set_visible(false);
         } else {
             imp.counter_spinbutton.set_visible(false);
             imp.period_row.set_visible(true);
-            imp.period_label.set_text(&provider.period().to_string());
+            imp.period_row.set_subtitle(&provider.period().to_string());
         }
-        imp.digits_label.set_text(&provider.digits().to_string());
+        imp.digits_row.set_subtitle(&provider.digits().to_string());
         if let Some(help) = provider.help_url() {
             imp.help_row.set_uri(help);
             imp.help_row.set_visible(true);