diff --git a/src/main/java/com/simibubi/create/content/contraptions/AbstractContraptionEntity.java b/src/main/java/com/simibubi/create/content/contraptions/AbstractContraptionEntity.java index f8e3caf9f..3e254604d 100644 --- a/src/main/java/com/simibubi/create/content/contraptions/AbstractContraptionEntity.java +++ b/src/main/java/com/simibubi/create/content/contraptions/AbstractContraptionEntity.java @@ -545,9 +545,12 @@ public abstract class AbstractContraptionEntity extends Entity implements IEntit relativeMotion = reverseRotation(relativeMotion, 1); context.relativeMotion = relativeMotion; - return !BlockPos.containing(previousPosition).equals(gridPosition) - || (context.relativeMotion.length() > 0 || context.contraption instanceof CarriageContraption) - && context.firstMovement; + boolean ignoreMotionForFirstMovement = + context.contraption instanceof CarriageContraption || actor instanceof PortableStorageInterfaceMovement; + + return !BlockPos.containing(previousPosition) + .equals(gridPosition) + || (context.relativeMotion.length() > 0 || ignoreMotionForFirstMovement) && context.firstMovement; } public void move(double x, double y, double z) { diff --git a/src/main/java/com/simibubi/create/content/fluids/tank/FluidTankBlock.java b/src/main/java/com/simibubi/create/content/fluids/tank/FluidTankBlock.java index b2b29a87f..50a7f7ebf 100644 --- a/src/main/java/com/simibubi/create/content/fluids/tank/FluidTankBlock.java +++ b/src/main/java/com/simibubi/create/content/fluids/tank/FluidTankBlock.java @@ -106,7 +106,7 @@ public class FluidTankBlock extends Block implements IWrenchable, IBE(this::onHandlerInvalidated, this)); - } - @Override public void lazyTick() { super.lazyTick(); @@ -132,8 +127,6 @@ public abstract class CapManipulationBehaviourBase capability = capability(); targetCapability = bypassSided ? invBE.getCapability(capability) : invBE.getCapability(capability, targetBlockFace.getFace()); - if (targetCapability.isPresent()) - targetCapability.addListener(new HashableNonNullConsumer<>(this::onHandlerInvalidated, this)); } @FunctionalInterface diff --git a/src/main/java/com/simibubi/create/foundation/fluid/FluidHelper.java b/src/main/java/com/simibubi/create/foundation/fluid/FluidHelper.java index e00cbd7d3..7e47daee6 100644 --- a/src/main/java/com/simibubi/create/foundation/fluid/FluidHelper.java +++ b/src/main/java/com/simibubi/create/foundation/fluid/FluidHelper.java @@ -53,11 +53,11 @@ public class FluidHelper { public static boolean isLava(Fluid fluid) { return convertToStill(fluid) == Fluids.LAVA; } - + public static boolean isSame(FluidStack fluidStack, FluidStack fluidStack2) { return fluidStack.getFluid() == fluidStack2.getFluid(); } - + public static boolean isSame(FluidStack fluidStack, Fluid fluid) { return fluidStack.getFluid() == fluid; } @@ -147,6 +147,8 @@ public class FluidHelper { Fluid fluid = ForgeRegistries.FLUIDS.getValue(id); if (fluid == null) throw new JsonSyntaxException("Unknown fluid '" + id + "'"); + if (fluid == Fluids.EMPTY) + throw new JsonSyntaxException("Invalid empty fluid '" + id + "'"); int amount = GsonHelper.getAsInt(json, "amount"); FluidStack stack = new FluidStack(fluid, amount); diff --git a/src/main/java/com/simibubi/create/foundation/fluid/FluidIngredient.java b/src/main/java/com/simibubi/create/foundation/fluid/FluidIngredient.java index ce69e7579..5672f1b83 100644 --- a/src/main/java/com/simibubi/create/foundation/fluid/FluidIngredient.java +++ b/src/main/java/com/simibubi/create/foundation/fluid/FluidIngredient.java @@ -124,7 +124,7 @@ public abstract class FluidIngredient implements Predicate { public static FluidIngredient deserialize(@Nullable JsonElement je) { if (!isFluidIngredient(je)) - throw new JsonSyntaxException("Invalid fluid ingredient: " + Objects.toString(je)); + throw new JsonSyntaxException("Invalid fluid ingredient: " + je); JsonObject json = je.getAsJsonObject(); FluidIngredient ingredient = json.has("fluidTag") ? new FluidTagIngredient() : new FluidStackIngredient(); diff --git a/src/main/resources/META-INF/mods.toml b/src/main/resources/META-INF/mods.toml index a44a4ccca..b84c313c9 100644 --- a/src/main/resources/META-INF/mods.toml +++ b/src/main/resources/META-INF/mods.toml @@ -19,7 +19,7 @@ Technology that empowers the player.''' [[dependencies.create]] modId="forge" mandatory=true - versionRange="[47.1.43,)" + versionRange="[47.1.3,)" ordering="NONE" side="BOTH"