mirrors/Create
0
0
Fork 0
mirror of https://github.com/Creators-of-Create/Create.git synced 2024-12-29 08:27:03 +01:00
Code Issues Projects Releases Packages Wiki Activity

Improve comment clarity on height-related methods in ContraptionWorld and WrappedWorld

Browse source
This commit is contained in:
Aeiou 2021-12-30 15:32:55 -05:00
parent a12708b336
commit 345b83ee90
2 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
src/main/java/com/simibubi/create/content/contraptions/components/structureMovement/ContraptionWorld.java
View file

@ -46,7 +46,8 @@ public class ContraptionWorld extends WrappedWorld {
world.playLocalSound(x, y, z, p_184134_7_, p_184134_8_, p_184134_9_, p_184134_10_, p_184134_11_); world.playLocalSound(x, y, z, p_184134_7_, p_184134_8_, p_184134_9_, p_184134_10_, p_184134_11_);
} }
// Calculate lazily to avoid issues on load when the bounds are yet to be determined. // Ensure that we provide accurate information about ContraptionWorld height to mods (such as Starlight) which
// expect Levels to only have blocks located in chunks within their height range.
@Override @Override
public int getHeight() { public int getHeight() {

5
src/main/java/com/simibubi/create/foundation/utility/worldWrappers/WrappedWorld.java
View file

@ -200,7 +200,10 @@ public class WrappedWorld extends Level {
return entityGetter; return entityGetter;
} }
// Intentionally copied from LevelHeightAccessor. Lithium overrides these methods so we need to, too. // Intentionally copied from LevelHeightAccessor. Workaround for issues caused when other mods (such as Lithium)
// override the vanilla implementations in ways which cause WrappedWorlds to return incorrect, default height info.
// WrappedWorld subclasses should implement their own getMinBuildHeight and getHeight overrides where they deviate
// from the defaults for their dimension.
@Override @Override
public int getMaxBuildHeight() { public int getMaxBuildHeight() {