From b1aeba61c0f1623f31f46fc51c088038f5330c1c Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Fri, 20 Nov 2020 23:03:13 -0800 Subject: [PATCH 1/7] Add network direction designation --- .../foundation/networking/AllPackets.java | 70 ++++++++++--------- 1 file changed, 38 insertions(+), 32 deletions(-) diff --git a/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java b/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java index 8feb79656..f7c6ed4af 100644 --- a/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java +++ b/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java @@ -25,8 +25,8 @@ import com.simibubi.create.content.logistics.packet.ConfigureStockswitchPacket; import com.simibubi.create.content.schematics.packet.ConfigureSchematicannonPacket; import com.simibubi.create.content.schematics.packet.InstantSchematicPacket; import com.simibubi.create.content.schematics.packet.SchematicPlacePacket; -import com.simibubi.create.content.schematics.packet.SchematicUploadPacket; import com.simibubi.create.content.schematics.packet.SchematicSyncPacket; +import com.simibubi.create.content.schematics.packet.SchematicUploadPacket; import com.simibubi.create.foundation.command.ConfigureConfigPacket; import com.simibubi.create.foundation.tileEntity.behaviour.filtering.FilteringCountUpdatePacket; import com.simibubi.create.foundation.tileEntity.behaviour.scrollvalue.ScrollValueUpdatePacket; @@ -36,44 +36,48 @@ import net.minecraft.network.PacketBuffer; import net.minecraft.util.ResourceLocation; import net.minecraft.util.math.BlockPos; import net.minecraft.world.World; +import net.minecraftforge.fml.network.NetworkDirection; import net.minecraftforge.fml.network.NetworkEvent.Context; import net.minecraftforge.fml.network.NetworkRegistry; import net.minecraftforge.fml.network.PacketDistributor; import net.minecraftforge.fml.network.PacketDistributor.TargetPoint; import net.minecraftforge.fml.network.simple.SimpleChannel; +import static net.minecraftforge.fml.network.NetworkDirection.PLAY_TO_SERVER; +import static net.minecraftforge.fml.network.NetworkDirection.PLAY_TO_CLIENT; + public enum AllPackets { // Client to Server - NBT(NbtPacket.class, NbtPacket::new), - CONFIGURE_SCHEMATICANNON(ConfigureSchematicannonPacket.class, ConfigureSchematicannonPacket::new), - CONFIGURE_FLEXCRATE(ConfigureFlexcratePacket.class, ConfigureFlexcratePacket::new), - CONFIGURE_STOCKSWITCH(ConfigureStockswitchPacket.class, ConfigureStockswitchPacket::new), - CONFIGURE_SEQUENCER(ConfigureSequencedGearshiftPacket.class, ConfigureSequencedGearshiftPacket::new), - PLACE_SCHEMATIC(SchematicPlacePacket.class, SchematicPlacePacket::new), - UPLOAD_SCHEMATIC(SchematicUploadPacket.class, SchematicUploadPacket::new), - CONFIGURE_FILTER(FilterScreenPacket.class, FilterScreenPacket::new), - CONFIGURE_FILTERING_AMOUNT(FilteringCountUpdatePacket.class, FilteringCountUpdatePacket::new), - CONFIGURE_SCROLLABLE(ScrollValueUpdatePacket.class, ScrollValueUpdatePacket::new), - EXTENDO_INTERACT(ExtendoGripInteractionPacket.class, ExtendoGripInteractionPacket::new), - CONTRAPTION_INTERACT(ContraptionInteractionPacket.class, ContraptionInteractionPacket::new), - CLIENT_MOTION(ClientMotionPacket.class, ClientMotionPacket::new), - PLACE_ARM(ArmPlacementPacket.class, ArmPlacementPacket::new), - MINECART_COUPLING_CREATION(CouplingCreationPacket.class, CouplingCreationPacket::new), - INSTANT_SCHEMATIC(InstantSchematicPacket.class, InstantSchematicPacket::new), - SYNC_SCHEMATIC(SchematicSyncPacket.class, SchematicSyncPacket::new), + NBT(NbtPacket.class, NbtPacket::new, PLAY_TO_SERVER), + CONFIGURE_SCHEMATICANNON(ConfigureSchematicannonPacket.class, ConfigureSchematicannonPacket::new, PLAY_TO_SERVER), + CONFIGURE_FLEXCRATE(ConfigureFlexcratePacket.class, ConfigureFlexcratePacket::new, PLAY_TO_SERVER), + CONFIGURE_STOCKSWITCH(ConfigureStockswitchPacket.class, ConfigureStockswitchPacket::new, PLAY_TO_SERVER), + CONFIGURE_SEQUENCER(ConfigureSequencedGearshiftPacket.class, ConfigureSequencedGearshiftPacket::new, PLAY_TO_SERVER), + PLACE_SCHEMATIC(SchematicPlacePacket.class, SchematicPlacePacket::new, PLAY_TO_SERVER), + UPLOAD_SCHEMATIC(SchematicUploadPacket.class, SchematicUploadPacket::new, PLAY_TO_SERVER), + CONFIGURE_FILTER(FilterScreenPacket.class, FilterScreenPacket::new, PLAY_TO_SERVER), + CONFIGURE_FILTERING_AMOUNT(FilteringCountUpdatePacket.class, FilteringCountUpdatePacket::new, PLAY_TO_SERVER), + CONFIGURE_SCROLLABLE(ScrollValueUpdatePacket.class, ScrollValueUpdatePacket::new, PLAY_TO_SERVER), + EXTENDO_INTERACT(ExtendoGripInteractionPacket.class, ExtendoGripInteractionPacket::new, PLAY_TO_SERVER), + CONTRAPTION_INTERACT(ContraptionInteractionPacket.class, ContraptionInteractionPacket::new, PLAY_TO_SERVER), + CLIENT_MOTION(ClientMotionPacket.class, ClientMotionPacket::new, PLAY_TO_SERVER), + PLACE_ARM(ArmPlacementPacket.class, ArmPlacementPacket::new, PLAY_TO_SERVER), + MINECART_COUPLING_CREATION(CouplingCreationPacket.class, CouplingCreationPacket::new, PLAY_TO_SERVER), + INSTANT_SCHEMATIC(InstantSchematicPacket.class, InstantSchematicPacket::new, PLAY_TO_SERVER), + SYNC_SCHEMATIC(SchematicSyncPacket.class, SchematicSyncPacket::new, PLAY_TO_SERVER), // Server to Client - SYMMETRY_EFFECT(SymmetryEffectPacket.class, SymmetryEffectPacket::new), - SERVER_SPEED(ServerSpeedProvider.Packet.class, ServerSpeedProvider.Packet::new), - BEAM_EFFECT(ZapperBeamPacket.class, ZapperBeamPacket::new), - CONFIGURE_CONFIG(ConfigureConfigPacket.class, ConfigureConfigPacket::new), - CONTRAPTION_STALL(ContraptionStallPacket.class, ContraptionStallPacket::new), - GLUE_EFFECT(GlueEffectPacket.class, GlueEffectPacket::new), - CONTRAPTION_SEAT_MAPPING(ContraptionSeatMappingPacket.class, ContraptionSeatMappingPacket::new), - LIMBSWING_UPDATE(LimbSwingUpdatePacket.class, LimbSwingUpdatePacket::new), - MINECART_CONTROLLER(MinecartControllerUpdatePacket.class, MinecartControllerUpdatePacket::new), - FLUID_SPLASH(FluidSplashPacket.class, FluidSplashPacket::new), + SYMMETRY_EFFECT(SymmetryEffectPacket.class, SymmetryEffectPacket::new, PLAY_TO_CLIENT), + SERVER_SPEED(ServerSpeedProvider.Packet.class, ServerSpeedProvider.Packet::new, PLAY_TO_CLIENT), + BEAM_EFFECT(ZapperBeamPacket.class, ZapperBeamPacket::new, PLAY_TO_CLIENT), + CONFIGURE_CONFIG(ConfigureConfigPacket.class, ConfigureConfigPacket::new, PLAY_TO_CLIENT), + CONTRAPTION_STALL(ContraptionStallPacket.class, ContraptionStallPacket::new, PLAY_TO_CLIENT), + GLUE_EFFECT(GlueEffectPacket.class, GlueEffectPacket::new, PLAY_TO_CLIENT), + CONTRAPTION_SEAT_MAPPING(ContraptionSeatMappingPacket.class, ContraptionSeatMappingPacket::new, PLAY_TO_CLIENT), + LIMBSWING_UPDATE(LimbSwingUpdatePacket.class, LimbSwingUpdatePacket::new, PLAY_TO_CLIENT), + MINECART_CONTROLLER(MinecartControllerUpdatePacket.class, MinecartControllerUpdatePacket::new, PLAY_TO_CLIENT), + FLUID_SPLASH(FluidSplashPacket.class, FluidSplashPacket::new, PLAY_TO_CLIENT), ; @@ -83,8 +87,8 @@ public enum AllPackets { private LoadedPacket packet; - private AllPackets(Class type, Function factory) { - packet = new LoadedPacket<>(type, factory); + private AllPackets(Class type, Function factory, NetworkDirection direction) { + packet = new LoadedPacket<>(type, factory, direction); } public static void registerPackets() { @@ -110,16 +114,18 @@ public enum AllPackets { Function decoder; BiConsumer> handler; Class type; + NetworkDirection direction; - private LoadedPacket(Class type, Function factory) { + private LoadedPacket(Class type, Function factory, NetworkDirection direction) { encoder = T::write; decoder = factory; handler = T::handle; this.type = type; + this.direction = direction; } private void register() { - channel.messageBuilder(type, index++) + channel.messageBuilder(type, index++, direction) .encoder(encoder) .decoder(decoder) .consumer(handler) From e1d1b062f8fc5b18f3ae83b381396a3970304953 Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Sat, 21 Nov 2020 18:20:49 -0800 Subject: [PATCH 2/7] Enforce network version --- .../com/simibubi/create/foundation/networking/AllPackets.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java b/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java index f7c6ed4af..8bb4a5f83 100644 --- a/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java +++ b/src/main/java/com/simibubi/create/foundation/networking/AllPackets.java @@ -93,8 +93,8 @@ public enum AllPackets { public static void registerPackets() { channel = NetworkRegistry.ChannelBuilder.named(CHANNEL_NAME) - .serverAcceptedVersions(s -> true) - .clientAcceptedVersions(s -> true) + .serverAcceptedVersions(NETWORK_VERSION::equals) + .clientAcceptedVersions(NETWORK_VERSION::equals) .networkProtocolVersion(() -> NETWORK_VERSION) .simpleChannel(); for (AllPackets packet : values()) From 7c8bd28421040a783e2637df083a86c63bc326cd Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Sat, 21 Nov 2020 18:28:05 -0800 Subject: [PATCH 3/7] Restrict schematicannon configuration --- .../packet/ConfigureSchematicannonPacket.java | 35 +++++-------------- 1 file changed, 8 insertions(+), 27 deletions(-) diff --git a/src/main/java/com/simibubi/create/content/schematics/packet/ConfigureSchematicannonPacket.java b/src/main/java/com/simibubi/create/content/schematics/packet/ConfigureSchematicannonPacket.java index 4a5984e77..2e66fc255 100644 --- a/src/main/java/com/simibubi/create/content/schematics/packet/ConfigureSchematicannonPacket.java +++ b/src/main/java/com/simibubi/create/content/schematics/packet/ConfigureSchematicannonPacket.java @@ -2,15 +2,13 @@ package com.simibubi.create.content.schematics.packet; import java.util.function.Supplier; +import com.simibubi.create.content.schematics.block.SchematicannonContainer; import com.simibubi.create.content.schematics.block.SchematicannonTileEntity; import com.simibubi.create.content.schematics.block.SchematicannonTileEntity.State; import com.simibubi.create.foundation.networking.SimplePacketBase; import net.minecraft.entity.player.ServerPlayerEntity; import net.minecraft.network.PacketBuffer; -import net.minecraft.tileentity.TileEntity; -import net.minecraft.util.math.BlockPos; -import net.minecraft.world.World; import net.minecraftforge.fml.network.NetworkEvent.Context; public class ConfigureSchematicannonPacket extends SimplePacketBase { @@ -21,45 +19,28 @@ public class ConfigureSchematicannonPacket extends SimplePacketBase { private Option option; private boolean set; - private BlockPos pos; - public static ConfigureSchematicannonPacket setOption(BlockPos pos, Option option, boolean set) { - ConfigureSchematicannonPacket packet = new ConfigureSchematicannonPacket(pos); - packet.option = option; - packet.set = set; - return packet; - } - - public ConfigureSchematicannonPacket(BlockPos pos) { - this.pos = pos; + public ConfigureSchematicannonPacket(Option option, boolean set) { + this.option = option; + this.set = set; } public ConfigureSchematicannonPacket(PacketBuffer buffer) { - pos = buffer.readBlockPos(); - option = Option.values()[buffer.readInt()]; - set = buffer.readBoolean(); + this(buffer.readEnumValue(Option.class), buffer.readBoolean()); } public void write(PacketBuffer buffer) { - buffer.writeBlockPos(pos); - buffer.writeInt(option.ordinal()); + buffer.writeEnumValue(option); buffer.writeBoolean(set); } public void handle(Supplier context) { context.get().enqueueWork(() -> { ServerPlayerEntity player = context.get().getSender(); - if (player == null) - return; - World world = player.world; - if (world == null || !world.isBlockPresent(pos)) + if (player == null || !(player.openContainer instanceof SchematicannonContainer)) return; - TileEntity tileEntity = world.getTileEntity(pos); - if (!(tileEntity instanceof SchematicannonTileEntity)) - return; - - SchematicannonTileEntity te = (SchematicannonTileEntity) tileEntity; + SchematicannonTileEntity te = ((SchematicannonContainer) player.openContainer).getTileEntity(); switch (option) { case DONT_REPLACE: case REPLACE_ANY: From fe8c3d4e73360aa48d75a51677ee393af13fd2e1 Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Sat, 21 Nov 2020 19:28:54 -0800 Subject: [PATCH 4/7] Add nbt privilege checks --- .../schematics/SchematicProcessor.java | 59 +++++++++++++++++++ .../schematics/item/SchematicItem.java | 2 + 2 files changed, 61 insertions(+) create mode 100644 src/main/java/com/simibubi/create/content/schematics/SchematicProcessor.java diff --git a/src/main/java/com/simibubi/create/content/schematics/SchematicProcessor.java b/src/main/java/com/simibubi/create/content/schematics/SchematicProcessor.java new file mode 100644 index 000000000..f6d1a61d3 --- /dev/null +++ b/src/main/java/com/simibubi/create/content/schematics/SchematicProcessor.java @@ -0,0 +1,59 @@ +package com.simibubi.create.content.schematics; + +import com.mojang.datafixers.Dynamic; +import com.mojang.datafixers.types.DynamicOps; +import net.minecraft.entity.Entity; +import net.minecraft.entity.EntityType; +import net.minecraft.tileentity.TileEntity; +import net.minecraft.util.math.BlockPos; +import net.minecraft.world.IWorldReader; +import net.minecraft.world.World; +import net.minecraft.world.gen.feature.template.IStructureProcessorType; +import net.minecraft.world.gen.feature.template.PlacementSettings; +import net.minecraft.world.gen.feature.template.StructureProcessor; +import net.minecraft.world.gen.feature.template.Template; + +import javax.annotation.Nullable; +import java.util.Optional; + +public class SchematicProcessor extends StructureProcessor { + public static final SchematicProcessor INSTANCE = new SchematicProcessor(); + + @Nullable + @Override + public Template.BlockInfo process(IWorldReader world, BlockPos pos, Template.BlockInfo rawInfo, Template.BlockInfo info, PlacementSettings settings, @Nullable Template template) { + if (info.nbt != null) { + TileEntity te = info.state.createTileEntity(world); + if (te != null && te.onlyOpsCanSetNbt()) { + return new Template.BlockInfo(info.pos, info.state, null); + } + } + return info; + } + + @Nullable + @Override + public Template.EntityInfo processEntity(IWorldReader world, BlockPos pos, Template.EntityInfo rawInfo, Template.EntityInfo info, PlacementSettings settings, Template template) { + return EntityType.readEntityType(info.nbt) + .flatMap(type -> { + if (world instanceof World) { + Entity e = type.create((World) world); + if (e != null && !e.ignoreItemEntityData()) { + return Optional.of(info); + } + } + return Optional.empty(); + }) + .orElse(null); + } + + @Override + protected IStructureProcessorType getType() { + return dynamic -> INSTANCE; + } + + @Override + protected Dynamic serialize0(DynamicOps ops) { + return new Dynamic<>(ops, ops.emptyMap()); + } +} diff --git a/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java b/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java index 2ddf14b10..ac7771002 100644 --- a/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java +++ b/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java @@ -12,6 +12,7 @@ import javax.annotation.Nonnull; import org.apache.commons.io.IOUtils; import com.simibubi.create.AllItems; +import com.simibubi.create.content.schematics.SchematicProcessor; import com.simibubi.create.content.schematics.client.SchematicEditScreen; import com.simibubi.create.foundation.gui.ScreenOpener; import com.simibubi.create.foundation.utility.Lang; @@ -94,6 +95,7 @@ public class SchematicItem extends Item { PlacementSettings settings = new PlacementSettings(); settings.setRotation(Rotation.valueOf(tag.getString("Rotation"))); settings.setMirror(Mirror.valueOf(tag.getString("Mirror"))); + settings.addProcessor(SchematicProcessor.INSTANCE); return settings; } From 6e131583dd39bf5e7359c4de031261a240ce15c0 Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Sat, 21 Nov 2020 21:19:38 -0800 Subject: [PATCH 5/7] Fix path handling --- .../schematics/ServerSchematicLoader.java | 79 ++++++++++--------- .../schematics/item/SchematicItem.java | 38 +++++---- .../foundation/utility/FilesHelper.java | 15 +--- 3 files changed, 67 insertions(+), 65 deletions(-) diff --git a/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java b/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java index 8c8e117fa..5c2ee7466 100644 --- a/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java +++ b/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java @@ -91,10 +91,8 @@ public class ServerSchematicLoader { } public void handleNewUpload(ServerPlayerEntity player, String schematic, long size, BlockPos pos) { - String playerPath = getSchematicPath() + "/" + player.getName() - .getFormattedText(); - String playerSchematicId = player.getName() - .getFormattedText() + "/" + schematic; + String playerPath = getSchematicPath() + "/" + player.getGameProfile().getName(); + String playerSchematicId = player.getGameProfile().getName() + "/" + schematic; FilesHelper.createFolderIfMissing(playerPath); // Unsupported Format @@ -103,6 +101,14 @@ public class ServerSchematicLoader { return; } + Path schematicPath = Paths.get(getSchematicPath()).toAbsolutePath(); + + Path uploadPath = schematicPath.resolve(playerSchematicId).normalize(); + if (!uploadPath.startsWith(schematicPath)) { + Create.logger.warn("Attempted Schematic Upload with directory escape: {}", playerSchematicId); + return; + } + // Too big if (!validateSchematicSizeOnServer(player, size)) return; @@ -117,12 +123,13 @@ public class ServerSchematicLoader { if (table == null) return; - // Delete schematic with same name - Files.deleteIfExists(Paths.get(getSchematicPath(), playerSchematicId)); - // Too many Schematics - Stream list = Files.list(Paths.get(playerPath)); - if (list.count() >= getConfig().maxSchematics.get()) { + long count; + try (Stream list = Files.list(Paths.get(playerPath))) { + count = list.count(); + } + + if (count >= getConfig().maxSchematics.get()) { Stream list2 = Files.list(Paths.get(playerPath)); Optional lastFilePath = list2.filter(f -> !Files.isDirectory(f)) .min(Comparator.comparingLong(f -> f.toFile() @@ -132,11 +139,9 @@ public class ServerSchematicLoader { Files.deleteIfExists(lastFilePath.get()); } } - list.close(); // Open Stream - OutputStream writer = - Files.newOutputStream(Paths.get(getSchematicPath(), playerSchematicId), StandardOpenOption.CREATE_NEW); + OutputStream writer = Files.newOutputStream(uploadPath); activeUploads.put(playerSchematicId, new SchematicUploadEntry(writer, size, player.getServerWorld(), pos)); // Notify Tile Entity @@ -165,8 +170,7 @@ public class ServerSchematicLoader { } public void handleWriteRequest(ServerPlayerEntity player, String schematic, byte[] data) { - String playerSchematicId = player.getName() - .getFormattedText() + "/" + schematic; + String playerSchematicId = player.getGameProfile().getName() + "/" + schematic; if (activeUploads.containsKey(playerSchematicId)) { SchematicUploadEntry entry = activeUploads.get(playerSchematicId); @@ -236,8 +240,7 @@ public class ServerSchematicLoader { } public void handleFinishedUpload(ServerPlayerEntity player, String schematic) { - String playerSchematicId = player.getName() - .getFormattedText() + "/" + schematic; + String playerSchematicId = player.getGameProfile().getName() + "/" + schematic; if (activeUploads.containsKey(playerSchematicId)) { try { @@ -258,8 +261,7 @@ public class ServerSchematicLoader { if (table == null) return; table.finishUpload(); - table.inventory.setStackInSlot(1, SchematicItem.create(schematic, player.getName() - .getFormattedText())); + table.inventory.setStackInSlot(1, SchematicItem.create(schematic, player.getGameProfile().getName())); } catch (IOException e) { Create.logger.error("Exception Thrown when finishing Upload: " + playerSchematicId); @@ -270,15 +272,21 @@ public class ServerSchematicLoader { public void handleInstantSchematic(ServerPlayerEntity player, String schematic, World world, BlockPos pos, BlockPos bounds) { - String playerPath = getSchematicPath() + "/" + player.getName() - .getFormattedText(); - String playerSchematicId = player.getName() - .getFormattedText() + "/" + schematic; + String playerPath = getSchematicPath() + "/" + player.getGameProfile().getName(); + String playerSchematicId = player.getGameProfile().getName() + "/" + schematic; FilesHelper.createFolderIfMissing(playerPath); // Unsupported Format if (!schematic.endsWith(".nbt")) { - Create.logger.warn("Attempted Schematic Upload with non-supported Format: " + playerSchematicId); + Create.logger.warn("Attempted Schematic Upload with non-supported Format: {}", playerSchematicId); + return; + } + + Path schematicPath = Paths.get(getSchematicPath()).toAbsolutePath(); + + Path path = schematicPath.resolve(playerSchematicId).normalize(); + if (!path.startsWith(schematicPath)) { + Create.logger.warn("Attempted Schematic Upload with directory escape: {}", playerSchematicId); return; } @@ -287,39 +295,32 @@ public class ServerSchematicLoader { return; try { - // Delete schematic with same name - Path path = Paths.get(getSchematicPath(), playerSchematicId); - Files.deleteIfExists(path); - // Too many Schematics - Stream list = Files.list(Paths.get(playerPath)); - if (list.count() >= getConfig().maxSchematics.get()) { + long count; + try (Stream list = Files.list(Paths.get(playerPath))) { + count = list.count(); + } + + if (count >= getConfig().maxSchematics.get()) { Stream list2 = Files.list(Paths.get(playerPath)); Optional lastFilePath = list2.filter(f -> !Files.isDirectory(f)) .min(Comparator.comparingLong(f -> f.toFile() .lastModified())); list2.close(); - if (lastFilePath.isPresent()) + if (lastFilePath.isPresent()) Files.deleteIfExists(lastFilePath.get()); } - list.close(); Template t = new Template(); t.takeBlocksFromWorld(world, pos, bounds, true, Blocks.AIR); - OutputStream outputStream = null; - try { - outputStream = Files.newOutputStream(path, StandardOpenOption.CREATE); + try (OutputStream outputStream = Files.newOutputStream(path)) { CompoundNBT nbttagcompound = t.writeToNBT(new CompoundNBT()); CompressedStreamTools.writeCompressed(nbttagcompound, outputStream); - player.setHeldItem(Hand.MAIN_HAND, SchematicItem.create(schematic, player.getName() - .getFormattedText())); + player.setHeldItem(Hand.MAIN_HAND, SchematicItem.create(schematic, player.getGameProfile().getName())); } catch (IOException e) { e.printStackTrace(); - } finally { - if (outputStream != null) - IOUtils.closeQuietly(outputStream); } } catch (IOException e) { Create.logger.error("Exception Thrown in direct Schematic Upload: " + playerSchematicId); diff --git a/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java b/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java index ac7771002..a07437758 100644 --- a/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java +++ b/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java @@ -3,13 +3,15 @@ package com.simibubi.create.content.schematics.item; import java.io.IOException; import java.io.InputStream; import java.nio.file.Files; +import java.nio.file.Path; import java.nio.file.Paths; import java.nio.file.StandardOpenOption; import java.util.List; import javax.annotation.Nonnull; -import org.apache.commons.io.IOUtils; +import org.apache.logging.log4j.LogManager; +import org.apache.logging.log4j.Logger; import com.simibubi.create.AllItems; import com.simibubi.create.content.schematics.SchematicProcessor; @@ -46,6 +48,8 @@ import net.minecraftforge.fml.common.thread.SidedThreadGroups; public class SchematicItem extends Item { + private static final Logger LOGGER = LogManager.getLogger(); + public SchematicItem(Properties properties) { super(properties.maxStackSize(1)); } @@ -106,25 +110,29 @@ public class SchematicItem extends Item { String schematic = blueprint.getTag() .getString("File"); - String filepath = ""; + if (!schematic.endsWith(".nbt")) + return t; - if (Thread.currentThread() - .getThreadGroup() == SidedThreadGroups.SERVER) - filepath = "schematics/uploaded/" + owner + "/" + schematic; - else - filepath = "schematics/" + schematic; + Path dir; + Path file; - InputStream stream = null; - try { - stream = Files.newInputStream(Paths.get(filepath), StandardOpenOption.READ); + if (Thread.currentThread().getThreadGroup() == SidedThreadGroups.SERVER) { + dir = Paths.get("schematics", "uploaded").toAbsolutePath(); + file = Paths.get(owner, schematic); + } else { + dir = Paths.get("schematics").toAbsolutePath(); + file = Paths.get(schematic); + } + + Path path = dir.resolve(file).normalize(); + if (!path.startsWith(dir)) + return t; + + try (InputStream stream = Files.newInputStream(path, StandardOpenOption.READ)) { CompoundNBT nbt = CompressedStreamTools.readCompressed(stream); t.read(nbt); - } catch (IOException e) { - // Player/Server doesnt have schematic saved - } finally { - if (stream != null) - IOUtils.closeQuietly(stream); + LOGGER.warn("Failed to read schematic", e); } return t; diff --git a/src/main/java/com/simibubi/create/foundation/utility/FilesHelper.java b/src/main/java/com/simibubi/create/foundation/utility/FilesHelper.java index 67bc3f1fa..e59a45521 100644 --- a/src/main/java/com/simibubi/create/foundation/utility/FilesHelper.java +++ b/src/main/java/com/simibubi/create/foundation/utility/FilesHelper.java @@ -21,17 +21,10 @@ import net.minecraft.nbt.CompoundNBT; public class FilesHelper { public static void createFolderIfMissing(String name) { - Path path = Paths.get(name); - if (path.getParent() != null) - createFolderIfMissing(path.getParent() - .toString()); - - if (!Files.isDirectory(path)) { - try { - Files.createDirectory(path); - } catch (IOException e) { - Create.logger.warn("Could not create Folder: " + name); - } + try { + Files.createDirectories(Paths.get(name)); + } catch (IOException e) { + Create.logger.warn("Could not create Folder: {}", name); } } From 18b768b32f3703f14ea22ed509c014332736fa1a Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Sat, 21 Nov 2020 22:00:05 -0800 Subject: [PATCH 6/7] Fix upload handling --- .../content/schematics/ServerSchematicLoader.java | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java b/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java index 5c2ee7466..743cc5a3b 100644 --- a/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java +++ b/src/main/java/com/simibubi/create/content/schematics/ServerSchematicLoader.java @@ -101,10 +101,10 @@ public class ServerSchematicLoader { return; } - Path schematicPath = Paths.get(getSchematicPath()).toAbsolutePath(); + Path playerSchematicsPath = Paths.get(getSchematicPath(), player.getGameProfile().getName()).toAbsolutePath(); - Path uploadPath = schematicPath.resolve(playerSchematicId).normalize(); - if (!uploadPath.startsWith(schematicPath)) { + Path uploadPath = playerSchematicsPath.resolve(schematic).normalize(); + if (!uploadPath.startsWith(playerSchematicsPath)) { Create.logger.warn("Attempted Schematic Upload with directory escape: {}", playerSchematicId); return; } @@ -123,6 +123,9 @@ public class ServerSchematicLoader { if (table == null) return; + // Delete schematic with same name + Files.deleteIfExists(uploadPath); + // Too many Schematics long count; try (Stream list = Files.list(Paths.get(playerPath))) { @@ -295,6 +298,9 @@ public class ServerSchematicLoader { return; try { + // Delete schematic with same name + Files.deleteIfExists(path); + // Too many Schematics long count; try (Stream list = Files.list(Paths.get(playerPath))) { From bc6513a098f3fb2007f365f23c9f222e5aef93c4 Mon Sep 17 00:00:00 2001 From: Paul Fulham Date: Sat, 21 Nov 2020 22:13:50 -0800 Subject: [PATCH 7/7] Limit schematic memory usage --- .../create/content/schematics/item/SchematicItem.java | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java b/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java index a07437758..1bef9185f 100644 --- a/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java +++ b/src/main/java/com/simibubi/create/content/schematics/item/SchematicItem.java @@ -1,12 +1,14 @@ package com.simibubi.create.content.schematics.item; +import java.io.BufferedInputStream; +import java.io.DataInputStream; import java.io.IOException; -import java.io.InputStream; import java.nio.file.Files; import java.nio.file.Path; import java.nio.file.Paths; import java.nio.file.StandardOpenOption; import java.util.List; +import java.util.zip.GZIPInputStream; import javax.annotation.Nonnull; @@ -27,6 +29,7 @@ import net.minecraft.item.ItemStack; import net.minecraft.item.ItemUseContext; import net.minecraft.nbt.CompoundNBT; import net.minecraft.nbt.CompressedStreamTools; +import net.minecraft.nbt.NBTSizeTracker; import net.minecraft.nbt.NBTUtil; import net.minecraft.util.ActionResult; import net.minecraft.util.ActionResultType; @@ -128,8 +131,9 @@ public class SchematicItem extends Item { if (!path.startsWith(dir)) return t; - try (InputStream stream = Files.newInputStream(path, StandardOpenOption.READ)) { - CompoundNBT nbt = CompressedStreamTools.readCompressed(stream); + try (DataInputStream stream = new DataInputStream(new BufferedInputStream( + new GZIPInputStream(Files.newInputStream(path, StandardOpenOption.READ))))) { + CompoundNBT nbt = CompressedStreamTools.read(stream, new NBTSizeTracker(0x20000000L)); t.read(nbt); } catch (IOException e) { LOGGER.warn("Failed to read schematic", e);