mirrors/Flywheel
0
0
Fork 0
mirror of https://github.com/Jozufozu/Flywheel.git synced 2025-01-23 19:37:53 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix lighting

Browse source
This commit is contained in:
IThundxr 2024-08-15 17:51:25 -04:00
parent 5313585f3e
commit 44f045b961
Failed to generate hash of commit
3 changed files with 0 additions and 39 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
common/src/main/java/dev/engine_room/flywheel/impl/event/RenderContextImpl.java
View file

@ -3,8 +3,6 @@ package dev.engine_room.flywheel.impl.event;
import org.joml.Matrix4f; import org.joml.Matrix4f;
import org.joml.Matrix4fc; import org.joml.Matrix4fc;
import com.mojang.blaze3d.vertex.PoseStack;
import dev.engine_room.flywheel.api.RenderContext; import dev.engine_room.flywheel.api.RenderContext;
import net.minecraft.client.Camera; import net.minecraft.client.Camera;
import net.minecraft.client.multiplayer.ClientLevel; import net.minecraft.client.multiplayer.ClientLevel;

36
common/src/main/java/dev/engine_room/flywheel/impl/mixin/fix/FixNormalScalingMixin.java
View file

@ -1,36 +0,0 @@
package dev.engine_room.flywheel.impl.mixin.fix;
import org.spongepowered.asm.mixin.Mixin;
import org.spongepowered.asm.mixin.injection.At;
import org.spongepowered.asm.mixin.injection.At.Shift;
import org.spongepowered.asm.mixin.injection.Inject;
import org.spongepowered.asm.mixin.injection.callback.CallbackInfo;
import com.mojang.blaze3d.vertex.PoseStack;
@Mixin(PoseStack.class)
abstract class FixNormalScalingMixin {
/**
* Minecraft negates the normal matrix if all scales are equal and negative, but
* does not return afterward. This allows the rest of the method's logic to be
* applied, which negates the matrix again, resulting in the matrix being the
* same as in the beginning.
*/
@Inject(method = "scale(FFF)V", at = @At(value = "INVOKE", target = "Lorg/joml/Matrix4f;scale(FFF)Lorg/joml/Matrix4f;", shift = Shift.AFTER, remap = false), cancellable = true)
private void flywheel$returnAfterNegate(float x, float y, float z, CallbackInfo ci) {
ci.cancel();
}
//fixme not needed anymore?
// /**
// * Minecraft takes the inverse cube root of the product of all scales to provide a
// * rough estimate for normalization so that it does not need to be done later. It
// * does not make sense for this "normalization factor" to be negative though, as
// * that would invert all normals. Additionally, Minecraft's fastInvCubeRoot method
// * does not work for negative numbers.
// */
// @ModifyArg(method = "scale(FFF)V", at = @At(value = "INVOKE", target = "Lnet/minecraft/util/Mth;fastInvCubeRoot(F)F"))
// private float flywheel$absInvCbrtInput(float input) {
// return Math.abs(input);
// }
}

1
common/src/main/resources/flywheel.impl.mixins.json
View file

@ -15,7 +15,6 @@
"MinecraftMixin", "MinecraftMixin",
"PoseStackMixin", "PoseStackMixin",
"fix.FixFabulousDepthMixin", "fix.FixFabulousDepthMixin",
"fix.FixNormalScalingMixin",
"visualmanage.BlockEntityMixin", "visualmanage.BlockEntityMixin",
"visualmanage.LevelChunkMixin", "visualmanage.LevelChunkMixin",
"visualmanage.LevelRendererMixin", "visualmanage.LevelRendererMixin",