From 867d0fa304317419eb4d364a8adfdfeb315cf1ff Mon Sep 17 00:00:00 2001 From: Jozufozu Date: Sun, 10 Dec 2023 15:55:04 -0800 Subject: [PATCH] TODONE - Do not check moreThanTwoThirdsChanged in IndirectInstancer#upload --- .../flywheel/backend/engine/indirect/IndirectInstancer.java | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/main/java/com/jozufozu/flywheel/backend/engine/indirect/IndirectInstancer.java b/src/main/java/com/jozufozu/flywheel/backend/engine/indirect/IndirectInstancer.java index 548057092..68e6ea9c8 100644 --- a/src/main/java/com/jozufozu/flywheel/backend/engine/indirect/IndirectInstancer.java +++ b/src/main/java/com/jozufozu/flywheel/backend/engine/indirect/IndirectInstancer.java @@ -38,10 +38,7 @@ public class IndirectInstancer extends AbstractInstancer } private boolean shouldUploadAll(long startPos) { - // If enough of the buffer has changed, write the whole thing to avoid the overhead of a bunch of small writes. - // TODO: The overhead comes from the driver performing many buffer copies. Using a compute shader to scatter - // the data should work much better. - return startPos != lastStartPos || moreThanTwoThirdsChanged(); + return startPos != lastStartPos; } private void uploadChanged(StagingBuffer stagingBuffer, long baseByte, int dstVbo) {