2023-08-18 00:00:52 +02:00
|
|
|
// apparmor.d - Full set of apparmor profiles
|
2024-02-07 00:16:21 +01:00
|
|
|
// Copyright (C) 2021-2024 Alexandre Pujol <alexandre@pujol.io>
|
2023-08-18 00:00:52 +02:00
|
|
|
// SPDX-License-Identifier: GPL-2.0-only
|
|
|
|
|
|
|
|
package aa
|
|
|
|
|
2024-05-25 23:14:43 +02:00
|
|
|
import (
|
|
|
|
"slices"
|
2024-06-20 00:30:36 +02:00
|
|
|
"strings"
|
|
|
|
|
2024-06-20 00:55:45 +02:00
|
|
|
"github.com/roddhjav/apparmor.d/pkg/util"
|
2024-05-25 23:14:43 +02:00
|
|
|
)
|
|
|
|
|
2024-05-25 23:01:29 +02:00
|
|
|
type requirement map[string][]string
|
|
|
|
|
2024-05-05 00:41:47 +02:00
|
|
|
type constraint uint
|
|
|
|
|
|
|
|
const (
|
|
|
|
anyKind constraint = iota // The rule can be found in either preamble or profile
|
|
|
|
preambleKind // The rule can only be found in the preamble
|
|
|
|
blockKind // The rule can only be found in a profile
|
|
|
|
)
|
|
|
|
|
2024-05-28 19:15:22 +02:00
|
|
|
// Kind represents an AppArmor rule kind.
|
|
|
|
type Kind string
|
|
|
|
|
|
|
|
func (k Kind) String() string {
|
|
|
|
return string(k)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (k Kind) Tok() string {
|
|
|
|
if t, ok := tok[k]; ok {
|
|
|
|
return t
|
|
|
|
}
|
|
|
|
return string(k)
|
|
|
|
}
|
|
|
|
|
2024-04-19 23:43:02 +02:00
|
|
|
// Rule generic interface for all AppArmor rules
|
|
|
|
type Rule interface {
|
2024-05-25 23:36:39 +02:00
|
|
|
Validate() error
|
2024-06-19 19:34:58 +02:00
|
|
|
Compare(other Rule) int
|
2024-04-23 22:26:09 +02:00
|
|
|
String() string
|
2024-05-05 00:41:47 +02:00
|
|
|
Constraint() constraint
|
2024-05-28 19:15:22 +02:00
|
|
|
Kind() Kind
|
2024-04-16 22:51:56 +02:00
|
|
|
}
|
|
|
|
|
2024-04-19 23:43:02 +02:00
|
|
|
type Rules []Rule
|
2024-04-16 22:51:56 +02:00
|
|
|
|
2024-05-25 23:36:39 +02:00
|
|
|
func (r Rules) Validate() error {
|
|
|
|
for _, rule := range r {
|
2024-05-29 22:17:21 +02:00
|
|
|
if rule == nil {
|
|
|
|
continue
|
|
|
|
}
|
2024-05-25 23:36:39 +02:00
|
|
|
if err := rule.Validate(); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2024-04-23 22:26:09 +02:00
|
|
|
func (r Rules) String() string {
|
|
|
|
return renderTemplate("rules", r)
|
|
|
|
}
|
2024-05-05 15:11:00 +02:00
|
|
|
|
2024-05-28 19:07:32 +02:00
|
|
|
// Index returns the index of the first occurrence of rule rin r, or -1 if not present.
|
2024-05-29 22:17:21 +02:00
|
|
|
func (r Rules) Index(item Rule) int {
|
|
|
|
for idx, rule := range r {
|
|
|
|
if rule == nil {
|
|
|
|
continue
|
|
|
|
}
|
2024-06-19 19:34:58 +02:00
|
|
|
if rule.Kind() == item.Kind() && rule.Compare(item) == 0 {
|
2024-05-26 19:05:15 +02:00
|
|
|
return idx
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return -1
|
|
|
|
}
|
|
|
|
|
2024-05-28 19:07:32 +02:00
|
|
|
// Replace replaces the elements r[i] by the given rules, and returns the
|
|
|
|
// modified slice.
|
|
|
|
func (r Rules) Replace(i int, rules ...Rule) Rules {
|
|
|
|
return append(r[:i], append(rules, r[i+1:]...)...)
|
2024-05-26 19:05:15 +02:00
|
|
|
}
|
|
|
|
|
2024-05-28 19:07:32 +02:00
|
|
|
// Insert inserts the rules into r at index i, returning the modified slice.
|
|
|
|
func (r Rules) Insert(i int, rules ...Rule) Rules {
|
|
|
|
return append(r[:i], append(rules, r[i:]...)...)
|
2024-05-26 19:05:15 +02:00
|
|
|
}
|
|
|
|
|
2024-05-28 19:07:32 +02:00
|
|
|
// Delete removes the elements r[i] from r, returning the modified slice.
|
|
|
|
func (r Rules) Delete(i int) Rules {
|
|
|
|
return append(r[:i], r[i+1:]...)
|
2024-05-26 19:05:15 +02:00
|
|
|
}
|
|
|
|
|
2024-05-28 19:15:22 +02:00
|
|
|
func (r Rules) DeleteKind(kind Kind) Rules {
|
2024-05-26 19:05:15 +02:00
|
|
|
res := make(Rules, 0)
|
|
|
|
for _, rule := range r {
|
2024-05-29 22:17:21 +02:00
|
|
|
if rule == nil {
|
|
|
|
continue
|
|
|
|
}
|
2024-05-26 19:05:15 +02:00
|
|
|
if rule.Kind() != kind {
|
|
|
|
res = append(res, rule)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return res
|
|
|
|
}
|
|
|
|
|
2024-05-28 19:15:22 +02:00
|
|
|
func (r Rules) Filter(filter Kind) Rules {
|
2024-05-05 15:11:00 +02:00
|
|
|
res := make(Rules, 0)
|
|
|
|
for _, rule := range r {
|
2024-05-29 22:17:21 +02:00
|
|
|
if rule == nil {
|
|
|
|
continue
|
|
|
|
}
|
2024-05-26 19:05:15 +02:00
|
|
|
if rule.Kind() != filter {
|
2024-05-05 15:11:00 +02:00
|
|
|
res = append(res, rule)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return res
|
|
|
|
}
|
|
|
|
|
|
|
|
func (r Rules) GetVariables() []*Variable {
|
|
|
|
res := make([]*Variable, 0)
|
|
|
|
for _, rule := range r {
|
2024-05-30 13:28:12 +02:00
|
|
|
switch rule := rule.(type) {
|
2024-05-05 15:11:00 +02:00
|
|
|
case *Variable:
|
2024-05-30 13:28:12 +02:00
|
|
|
res = append(res, rule)
|
2024-05-05 15:11:00 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return res
|
|
|
|
}
|
2024-05-25 23:14:43 +02:00
|
|
|
|
2024-05-25 23:21:59 +02:00
|
|
|
func (r Rules) GetIncludes() []*Include {
|
|
|
|
res := make([]*Include, 0)
|
|
|
|
for _, rule := range r {
|
2024-05-30 13:28:12 +02:00
|
|
|
switch rule := rule.(type) {
|
2024-05-25 23:21:59 +02:00
|
|
|
case *Include:
|
2024-05-30 13:28:12 +02:00
|
|
|
res = append(res, rule)
|
2024-05-25 23:21:59 +02:00
|
|
|
}
|
|
|
|
}
|
|
|
|
return res
|
|
|
|
}
|
|
|
|
|
2024-05-28 19:20:52 +02:00
|
|
|
// Merge merge similar rules together.
|
|
|
|
// Steps:
|
|
|
|
// - Remove identical rules
|
|
|
|
// - Merge rule access. Eg: for same path, 'r' and 'w' becomes 'rw'
|
|
|
|
//
|
|
|
|
// Note: logs.regCleanLogs helps a lot to do a first cleaning
|
|
|
|
func (r Rules) Merge() Rules {
|
|
|
|
for i := 0; i < len(r); i++ {
|
|
|
|
for j := i + 1; j < len(r); j++ {
|
2024-06-20 00:30:36 +02:00
|
|
|
if r[i] == nil && r[j] == nil {
|
|
|
|
r = r.Delete(j)
|
|
|
|
j--
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
if r[i] == nil || r[j] == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
kindOfI := r[i].Kind()
|
|
|
|
kindOfJ := r[j].Kind()
|
|
|
|
if kindOfI != kindOfJ {
|
2024-05-28 19:20:52 +02:00
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// If rules are identical, merge them
|
2024-06-19 19:34:58 +02:00
|
|
|
if r[i].Compare(r[j]) == 0 {
|
2024-05-28 19:20:52 +02:00
|
|
|
r = r.Delete(j)
|
|
|
|
j--
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
// File rule
|
2024-06-20 00:30:36 +02:00
|
|
|
if kindOfI == FILE && kindOfJ == FILE {
|
2024-05-28 19:20:52 +02:00
|
|
|
// Merge access
|
|
|
|
fileI := r[i].(*File)
|
|
|
|
fileJ := r[j].(*File)
|
|
|
|
if fileI.Path == fileJ.Path {
|
|
|
|
fileI.Access = append(fileI.Access, fileJ.Access...)
|
2024-06-19 19:34:58 +02:00
|
|
|
slices.SortFunc(fileI.Access, compareFileAccess)
|
2024-05-28 19:20:52 +02:00
|
|
|
fileI.Access = slices.Compact(fileI.Access)
|
|
|
|
r = r.Delete(j)
|
|
|
|
j--
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return r
|
|
|
|
}
|
|
|
|
|
|
|
|
// Sort the rules according to the guidelines:
|
|
|
|
// https://apparmor.pujol.io/development/guidelines/#guidelines
|
|
|
|
func (r Rules) Sort() Rules {
|
|
|
|
slices.SortFunc(r, func(a, b Rule) int {
|
|
|
|
kindOfA := a.Kind()
|
|
|
|
kindOfB := b.Kind()
|
|
|
|
if kindOfA != kindOfB {
|
|
|
|
if kindOfA == INCLUDE && a.(*Include).IfExists {
|
|
|
|
kindOfA = "include_if_exists"
|
|
|
|
}
|
|
|
|
if kindOfB == INCLUDE && b.(*Include).IfExists {
|
|
|
|
kindOfB = "include_if_exists"
|
|
|
|
}
|
|
|
|
return ruleWeights[kindOfA] - ruleWeights[kindOfB]
|
|
|
|
}
|
2024-06-19 19:34:58 +02:00
|
|
|
return a.Compare(b)
|
2024-05-28 19:20:52 +02:00
|
|
|
})
|
|
|
|
return r
|
|
|
|
}
|
|
|
|
|
|
|
|
// Format the rules for better readability before printing it.
|
|
|
|
// Follow: https://apparmor.pujol.io/development/guidelines/#the-file-block
|
|
|
|
func (r Rules) Format() Rules {
|
|
|
|
const prefixOwner = " "
|
2024-06-20 00:30:36 +02:00
|
|
|
suffixMaxlen := 36
|
|
|
|
transitions := append(requirements[FILE]["transition"], "m")
|
|
|
|
|
|
|
|
paddingIndex := []int{}
|
|
|
|
paddingMaxLenght := 0
|
|
|
|
for i, rule := range r {
|
|
|
|
if rule == nil {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
|
|
|
|
if rule.Kind() == FILE {
|
|
|
|
rule := r[i].(*File)
|
|
|
|
|
|
|
|
// Add padding to align with other transition rule
|
2024-06-20 00:55:45 +02:00
|
|
|
isTransition := util.Intersect(transitions, rule.Access)
|
2024-06-20 00:30:36 +02:00
|
|
|
if len(isTransition) > 0 {
|
|
|
|
ruleLen := len(rule.Path) + 1
|
|
|
|
paddingMaxLenght = max(ruleLen, paddingMaxLenght)
|
|
|
|
paddingIndex = append(paddingIndex, i)
|
|
|
|
}
|
|
|
|
|
|
|
|
// Add suffix to align comment on udev/data rule
|
|
|
|
if rule.Comment != "" && strings.HasPrefix(rule.Path, "@{run}/udev/data/") {
|
|
|
|
suffixlen := suffixMaxlen - len(rule.Path)
|
|
|
|
if suffixlen < 0 {
|
|
|
|
suffixlen = 0
|
|
|
|
}
|
|
|
|
rule.Suffix = strings.Repeat(" ", suffixlen)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if len(paddingIndex) > 1 {
|
|
|
|
r.setPadding(paddingIndex, paddingMaxLenght)
|
|
|
|
}
|
2024-05-28 19:20:52 +02:00
|
|
|
|
|
|
|
hasOwnerRule := false
|
2024-06-20 00:30:36 +02:00
|
|
|
for i := len(r) - 1; i >= 0; i-- {
|
|
|
|
if r[i] == nil {
|
|
|
|
hasOwnerRule = false
|
|
|
|
continue
|
|
|
|
}
|
2024-05-28 19:20:52 +02:00
|
|
|
|
|
|
|
// File rule
|
2024-06-20 00:30:36 +02:00
|
|
|
if r[i].Kind() == FILE {
|
|
|
|
rule := r[i].(*File)
|
2024-05-28 19:20:52 +02:00
|
|
|
|
|
|
|
// Add prefix before rule path to align with other rule
|
2024-06-20 00:30:36 +02:00
|
|
|
if rule.Owner {
|
2024-05-28 19:20:52 +02:00
|
|
|
hasOwnerRule = true
|
|
|
|
} else if hasOwnerRule {
|
2024-06-20 00:30:36 +02:00
|
|
|
rule.Prefix = prefixOwner
|
|
|
|
}
|
|
|
|
|
|
|
|
// Do not add new line on executable rule
|
2024-06-20 00:55:45 +02:00
|
|
|
isTransition := util.Intersect(transitions, rule.Access)
|
2024-06-20 00:30:36 +02:00
|
|
|
if len(isTransition) > 0 {
|
|
|
|
continue
|
2024-05-28 19:20:52 +02:00
|
|
|
}
|
|
|
|
|
2024-06-20 00:30:36 +02:00
|
|
|
// Add a new line between Files rule of different group type
|
|
|
|
j := i - 1
|
|
|
|
if j < 0 || r[j] == nil || r[j].Kind() != FILE {
|
|
|
|
continue
|
|
|
|
}
|
|
|
|
letterI := getLetterIn(fileAlphabet, rule.Path)
|
|
|
|
letterJ := getLetterIn(fileAlphabet, r[j].(*File).Path)
|
|
|
|
groupI, ok1 := fileAlphabetGroups[letterI]
|
|
|
|
groupJ, ok2 := fileAlphabetGroups[letterJ]
|
|
|
|
if letterI != letterJ && !(ok1 && ok2 && groupI == groupJ) {
|
2024-05-28 19:20:52 +02:00
|
|
|
hasOwnerRule = false
|
|
|
|
r = r.Insert(i, nil)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return r
|
|
|
|
}
|
2024-06-20 00:30:36 +02:00
|
|
|
|
|
|
|
// setPadding adds padding to the rule path to align with other rules.
|
|
|
|
func (r *Rules) setPadding(paddingIndex []int, paddingMaxLenght int) {
|
|
|
|
for _, i := range paddingIndex {
|
|
|
|
(*r)[i].(*File).Padding = strings.Repeat(" ", paddingMaxLenght-len((*r)[i].(*File).Path))
|
|
|
|
}
|
|
|
|
}
|