mirrors/apparmor.d
1
0
Fork 0
mirror of https://github.com/roddhjav/apparmor.d.git synced 2024-12-24 14:06:47 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

fix exec_path bug, ignore skipable files
Some checks failed
Ubuntu / check (push) Has been cancelled
Details
Ubuntu / build (default, ubuntu-22.04) (push) Has been cancelled
Details
Ubuntu / build (default, ubuntu-24.04) (push) Has been cancelled
Details
Ubuntu / build (full-system-policy, ubuntu-22.04) (push) Has been cancelled
Details
Ubuntu / build (full-system-policy, ubuntu-24.04) (push) Has been cancelled
Details
Ubuntu / tests (push) Has been cancelled
Details

Browse source
This commit is contained in:
nobody43 2024-11-23 19:54:17 +00:00 committed by Alex
parent 8f4b330407
commit edaa45067a
1 changed files with 15 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

26
tests/profile_check.py
View file

@ -186,14 +186,8 @@ def readApparmorFile(fullpath):
if m.get('profile'):
nestingStacker.append(m.get('profile')) # set early
if m.get('attachment') != '@{exec_path}' and not gotAttach: # can be only singular
if m.get('attachment') == '@{exec_path}' and not gotAttach: # can be only singular
gotAttach = True
messages.append({'filename': fullpath,
'profile': getCurrentProfile(nestingStacker),
'severity': 'WARNING',
'line': n,
'reason': "'@{exec_path}' must be defined as main path attachment",
'suggestion': None})
profileMsg = {'filename': fullpath,
'profile': getCurrentProfile(nestingStacker),
@ -324,6 +318,15 @@ def readApparmorFile(fullpath):
'reason': 'ABI is required',
'suggestion': abi})
# Ensure singular '@{exec_path}'
if not gotAttach:
messages.append({'filename': fullpath,
'profile': None,
'severity': 'WARNING',
'line': None,
'reason': "'@{exec_path}' must be defined as main path attachment",
'suggestion': None})
# Ensure trailing vim syntax
if line:
trailingSyntax = '# vim:syntax=apparmor\n'
@ -450,10 +453,11 @@ def main(argv):
profile_data = {}
for path in sorted(profiles):
readApparmorFile_Out = readApparmorFile(path)
profilesInFile = readApparmorFile_Out[1]
messages.extend(readApparmorFile_Out[0])
profile_data.update(profilesInFile)
if not is_skippable_file(path):
readApparmorFile_Out = readApparmorFile(path)
profilesInFile = readApparmorFile_Out[1]
messages.extend(readApparmorFile_Out[0])
profile_data.update(profilesInFile)
for m in messages:
if m.get('suggestion'):