The coredump regression test existed in the tree, but was not hooked up to

the testsuite. It looks like coredump mediation may have been removed,
since it is rather a corner-case, so I have currently marked it as XFAIL.

In hooking it back up, the "prologue.inc" was reviewed, dead code dropped,
and the "image=" argument changed to correctly handle the imageperms
syntax used elsewhere. It was working in other tests out of coincidence.

.bzrignore

@@ -237,3 +237,4 @@ tests/regression/apparmor/unix_fd_client
 tests/regression/apparmor/unix_fd_server
 tests/regression/apparmor/unlink
 tests/regression/apparmor/xattrs
+tests/regression/apparmor/coredump

tests/regression/apparmor/Makefile

@@ -22,6 +22,7 @@ SRC=access.c \
     chmod.c \
     chown.c \
     clone.c \
+    coredump.c \
     deleted.c \
     environ.c \
     env_check.c \
@@ -113,6 +114,7 @@ TESTS=access \
       changehat_misc \
       chdir \
       clone \
+      coredump \
       deleted \
       environ \
       exec \

tests/regression/apparmor/coredump.c

@@ -1,7 +1,9 @@
+#include <stdio.h>
 int *ptr;
 
 /*
  *	Copyright (C) 2002-2005 Novell/SUSE
+ *	Copyright (C) 2010 Canonical, Ltd
  *
  *	This program is free software; you can redistribute it and/or
  *	modify it under the terms of the GNU General Public License as
@@ -9,7 +11,7 @@ int *ptr;
  *	License.
  */
 
-main()
+int main(int argc, char *argv[])
 {
 	printf("This will cause a sigsegv\n");
 

tests/regression/apparmor/coredump.sh

@@ -1,7 +1,6 @@
 #! /bin/bash
-# $Id$
-
 #	Copyright (C) 2002-2005 Novell/SUSE
+#	Copyright (C) 2010 Canonical, Ltd
 #
 #	This program is free software; you can redistribute it and/or
 #	modify it under the terms of the GNU General Public License as
@@ -11,26 +10,52 @@
 #=NAME coredump
 #=DESCRIPTION coredump test
 
+cleancorefile()
+{
+	rm -f core core.*
+}
+
 checkcorefile()
 {
-_corefilelist=`echo core.*`
+	# global _testdesc _pfmode _known outfile
-if [ "$_corefilelist" = "core.*" ]
+	if [ ${1:0:1} == "x" ] ; then
-then
+		requirement=${1#x}
-	_corefile=no
+		_known=" (known problem)"
-else
+        else
-	_corefile=yes
+		requirement=$1
-fi
+		_known=""
+        fi
 
-if [ "$1" = "yes" -a "$_corefile" = "no" ]
+	_corefilelist=`echo core.*`
-then
+	if [ ! -f core ] && [ "$_corefilelist" = "core.*" ]
-	echo "Error: corefile expected but not present - $2"
+	then
-elif [ "$1" = "no" -a "$_corefile"  = "yes" ]
+		_corefile=no
-then
+	else
-	echo "Error: corefile present when not expected -- $2"
+		_corefile=yes
-fi
+	fi
 
-unset _corefile _corefilelist
+	if [ "$requirement" = "yes" -a "$_corefile" = "no" ] ; then
-rm -f core.*
+		if [ -n $_known ] ; then
+			echo -n "XFAIL: "
+		fi
+		echo "Error: corefile expected but not present - $2"
+		if [ -z $_known ] ; then
+			cat $profile
+			testfailed
+		fi
+	elif [ "$requirement" = "no" -a "$_corefile"  = "yes" ] ; then
+		if [ -n "$_known" ] ; then
+			echo -n "XFAIL: "
+		fi
+		echo "Error: corefile present when not expected -- $2"
+		if [ -z "$_known" ] ; then
+			cat $profile
+			testfailed
+		fi
+	fi
+
+	unset _corefile _corefilelist
+	cleancorefile
 }
 
 pwd=`dirname $0`
@@ -45,15 +70,18 @@ nocoreperm=ix
 
 # enable coredumps
 ulimit -c 1000000
+cleancorefile
+checkcorefile no "COREDUMP (starting with clean slate)"
 
 # PASS TEST, no confinement
+cleancorefile
 echo "*** A 'Segmentation Fault' message from bash is expected for the following test"
 runchecktest "COREDUMP (no confinement)" signal11
 checkcorefile yes "COREDUMP (no confinement)"
 
 # PASS TEST, with r confinement
-genprofile $test:$coreperm
+cleancorefile
-cat $profile
+genprofile image=$test:$coreperm
 
 echo
 echo "*** A 'Segmentation Fault' message from bash is expected for the following test"
@@ -61,10 +89,10 @@ runchecktest "COREDUMP ($coreperm confinement)" signal11
 checkcorefile yes "COREDUMP ($coreperm confinement)"
 
 # FAIL TEST, with x confinement
-genprofile $test:$nocoreperm
+cleancorefile
-cat $profile
+genprofile image=$test:$nocoreperm
 
 echo
 echo "*** A 'Segmentation Fault' message from bash is expected for the following test"
 runchecktest "COREDUMP ($nocoreperm confinement)" signal11
-checkcorefile no "COREDUMP ($nocoreperm confinement)"
+checkcorefile xno "COREDUMP ($nocoreperm confinement)"

tests/regression/apparmor/prologue.inc

@@ -415,22 +415,12 @@ fi
 		# it is most often used after --, in fact it is basically
 		# mandatory after --
 		case "$1" in
-			profile=*) imagename=`echo $1 | sed 's/^profile=[rix]*//'`
+			image=*) imagename=`echo $1 | sed 's/^image=\([^:]*\).*$/\1/'`
-				 perm=`echo $1 | sed -n 's/^profile=\([rix]*\).*$/\1/p'`
-				 if [ -n "$perm" ]
-				 then
-					imageperm=$perm
-				 fi
-				 num_emitted=0
-				 shift
-				 ;;
-
-			image=*) imagename=`echo $1 | sed 's/^image=[rix]*//'`
 				 if [ ! -x "$imagename" ]
 				 then
 					fatalerror "invalid imagename specified in input '$1'"
 				 fi
-				 perm=`echo $1 | sed -n 's/^image=\([rix]*\).*$/\1/p'`
+				 perm=`echo $1 | sed -n 's/^image=[^:]*:\(.*\)$/\1/p'`
 				 if [ -n "$perm" ]
 				 then
 					imageperm=$perm