mirrors/apparmor
1
0
Fork 0
mirror of https://gitlab.com/apparmor/apparmor.git synced 2025-03-04 08:24:42 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

error out on superfluous TODOs

Browse source 
If a test is marked as TODO, but matches its EXRESULT, this means the
TODO is superfluous and (probably) a change fixed what the TODO was for.

Instead of more or less ignoring such superfluous TODOs, error out to
make the change visible instantly.
This commit is contained in:
Christian Boltz 2018-09-20 00:49:42 +02:00
parent 608af94dff
commit 4b26850e14
Failed to generate hash of commit
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
parser/tst/simple.pl
View file

@ -131,9 +131,13 @@ sub test_profile {
} elsif ($coredump) { } elsif ($coredump) {
ok(0, "$profile: Produced core dump (signal $signal): $description"); ok(0, "$profile: Produced core dump (signal $signal): $description");
} elsif ($istodo) { } elsif ($istodo) {
TODO: { if ($expass != $result) {
local $TODO = "Unfixed testcase."; fail("TODO passed unexpectedly: $profile: $description");
ok($expass ? !$result : $result, "TODO: $profile: $description"); } else {
TODO: {
local $TODO = "Unfixed testcase.";
ok($expass ? !$result : $result, "TODO: $profile: $description");
}
} }
} else { } else {
ok($expass ? !$result : $result, "$profile: $description"); ok($expass ? !$result : $result, "$profile: $description");