mirror of
https://gitlab.com/apparmor/apparmor.git
synced 2025-03-04 00:14:44 +01:00
![]() The current behavior of priority rules can be non-intuitive with higher priority rules completely overriding lower priority rules even in permissions not held in common. This behavior does have use cases but its can be very confusing, and does not normal policy behavior Eg. priority=0 allow r /**, priority=1 deny w /**, will result in no allowed permissions even though the deny rule is only removing the w permission, beause the higher priority rule completely over ride lower priority permissions sets (including none shared permissions). Instead move to tracking the priority at a per permission level. This allows the w permission to still override at priority 1, while the read permission is allowed at priority 0. The final constructed state will still drop priority for the final permission set on the state. Note: this patch updates the equality tests for the cases where the complete override behavior was being tested for. The complete override behavior will be reintroduced in a future patch with a keyword extension, enabling that behavior to be used for ordered blocks etc. Signed-off-by: John Johansen <john.johansen@canonical.com> |
||
---|---|---|
.. | ||
dirtest | ||
errors | ||
features_files | ||
simple_tests | ||
caching.profile | ||
caching.py | ||
dirtest.sh | ||
equality.sh | ||
errors.py | ||
gen-dbus.py | ||
gen-xtrans.py | ||
Makefile | ||
minimize.sh | ||
mk_features_file.py | ||
parser.conf | ||
README | ||
simple.pl | ||
testlib.py | ||
uservars.conf | ||
valgrind_simple.py |
This is the README for the AppArmor parser regression testsuite. Running the testsuite --------------------- Running the tests is pretty easy, a simple 'make tests' should make it go, assuming the subdomain parser and perl are installed. There is a user configuration file 'uservars.conf'. If you wish to test against a different parser, or use a different set of profiles for the simple.pl test, you can change those settings in 'uservars.conf'. You can also override which parser is used through make by specifying the PARSER variable. For example, to run the tests on the system parser, run 'make PARSER=/sbin/apparmor_parser'. Adding to the testsuite ----------------------- The testsuite currently contains one testscript (simple.pl) and makes use of perl's Test::Simple, Test::Harness, and prove utilities (see 'perldoc Test::Tutorial', 'perldoc Test::Simple', 'perldoc Test::Harness', and 'man 1 prove' for more information on these). It should be relatively easy to extend the suite with other testscripts, as long as they're written using Test::Simple or can emulate the Test::Harness protocol. To add a script, add it to the TESTS variable in the Makefile, and it will included in the tests to be run. However, in many cases, it is not necessary to add an entire new testscript for a testcase. Instead, the simple testcase (see below) will run all the profiles it finds on the parser, thus adding testcases is usually as simple as writing a new profile with a couple of extra comments. Simple parsing tests (simple.pl) -------------------------------- This test script tests the parser front end's ability to identify legal profiles. It does this by running the parser against several legal and illegal profiles (in debug mode, so as not to load them into the module proper) The simple script has the parser attempt to parse all of the profiles named *.sd in the simple_tests/ subdirectory; thus, to add a new profile to test, simply add it to the simple_tests/ directory. The simple script also adds the testdir (simple_tests/ by default) to the parsers include path (assuming that particular bug has been fixed :-)). There is an includes/ subdir to place additional includes if necessary (we purposefully choose to use different directory names versus the shipped profiles to minimize testsuite breakage with changes in the external policy). The simple script looks for a few special comments in the profile, #=DESCRIPTION, #=EXRESULT, and #=TODO: - #=DESCRIPTION -- all text following the keyword is considered a description for the test. Please try to make these meaningful. - #=EXRESULT -- This records the expected result of parsing this profile. Values can either be PASS or FAIL; if no comment is found that matches this pattern, then the profile is assumed to have an expected parse result of PASS. - #=TODO -- marks the test as being for a future item to implement and thus are expected testsuite failures and should be ignored. - #=DISABLED -- skips the test, and marks it as a failed TODO task. Useful if the particular testcase causes the parser to infinite loop or dump core. Otherwise, the profile is passed on as-is to the subdomain parser.