mirror of
https://gitlab.com/apparmor/apparmor.git
synced 2025-03-04 08:24:42 +01:00
![]() Merge from trunk revision 2142 This patch fixes problems in the handling of both the final cache name location and the temporary cache file when an alternate location is specified. The first issue is that if the alternate cache directory location was specified, the alternate directory name would be used as the final location for the cache file, rather than the alternate directory + the basename of the profile. The second issue is that it would generate the temporary file that it stores the cache file in [basedir]/cache even if an alternate cache location was specified on the command line. This causes a problem if [basedir]/cache is on a separate device than the alternate cache location, because the rename() of the tempfile into the final location would fail (which the parser would not check the return code of). This patch fixes the above by incorporating the basename into the cache file name if the alternate cache location has been specified, bases the temporary cache file name on the destination cache name (such that they end up in the same directory), and finally detects if the rename fails and unlinks the temporary file if that happens (rather than leave it around). It also has been updated to add a couple of testcases to verify that writing and reading from an alternate cache location work. Patch history: v1: first draft of patch v2: add testcases, convert PERROR() to pwarn() if rename() fails for placing cachefile into place. For 2.8 branch: Signed-off-by: Steve Beattie <sbeattie@ubuntu.com> Acked-by: Seth Arnold <seth.arnold@canonical.com> |
||
---|---|---|
.. | ||
errors | ||
simple_tests | ||
caching.profile | ||
caching.sh | ||
gen-xtrans.pl | ||
Makefile | ||
minimize.sh | ||
README | ||
simple.pl | ||
uservars.conf |
This is the README for the AppArmor parser regression testsuite. Running the testsuite --------------------- Running the tests is pretty easy, a simple 'make tests' should make it go, assuming the subdomain parser and perl are installed. There is a user configuration file 'uservars.conf'. If you wish to test against a different parser, or use a different set of profiles for the simple.pl test, you can change those settings in 'uservars.conf'. Adding to the testsuite ----------------------- The testsuite currently contains one testscript (simple.pl) and makes use of perl's Test::Simple, Test::Harness, and prove utilities (see 'perldoc Test::Tutorial', 'perldoc Test::Simple', 'perldoc Test::Harness', and 'man 1 prove' for more information on these). It should be relatively easy to extend the suite with other testscripts, as long as they're written using Test::Simple or can emulate the Test::Harness protocol. To add a script, add it to the TESTS variable in the Makefile, and it will included in the tests to be run. However, in many cases, it is not necessary to add an entire new testscript for a testcase. Instead, the simple testcase (see below) will run all the profiles it finds on the parser, thus adding testcases is usually as simple as writing a new profile with a couple of extra comments. Simple parsing tests (simple.pl) -------------------------------- This test script tests the parser front end's ability to identify legal profiles. It does this by running the parser against several legal and illegal profiles (in debug mode, so as not to load them into the module proper) The simple script has the parser attempt to parse all of the profiles named *.sd in the simple_tests/ subdirectory; thus, to add a new profile to test, simply add it to the simple_tests/ directory. The simple script also adds the testdir (simple_tests/ by default) to the parsers include path (assuming that particular bug has been fixed :-)). There is an includes/ subdir to place additional includes if necessary (we purposefully choose to use different directory names versus the shipped profiles to minimize testsuite breakage with changes in the external policy). The simple script looks for a few special comments in the profile, #=DESCRIPTION, #=EXRESULT, and #=TODO: - #=DESCRIPTION -- all text following the keyword is considered a description for the test. Please try to make these meaningful. - #=EXRESULT -- This records the expected result of parsing this profile. Values can either be PASS or FAIL; if no comment is found that matches this pattern, then the profile is assumed to have an expected parse result of PASS. - #=TODO -- marks the test as being for a future item to implement and thus are expected testsuite failures and hsould be ignored. - #=DISABLED -- skips the test, and marks it as a failed TODO task. Useful if the particular testcase causes the parser to infinite loop. Otherwise, the profile is passed on as-is to the subdomain parser.