mirror of
https://gitlab.com/apparmor/apparmor.git
synced 2025-03-05 00:41:03 +01:00
124 lines
4.2 KiB
Diff
124 lines
4.2 KiB
Diff
From: Tony Jones <tonyj@suse.de>
|
|
Subject: Add a struct vfsmount parameter to vfs_symlink()
|
|
|
|
The vfsmount will be passed down to the LSM hook so that LSMs can compute
|
|
pathnames.
|
|
|
|
Signed-off-by: Tony Jones <tonyj@suse.de>
|
|
Signed-off-by: Andreas Gruenbacher <agruen@suse.de>
|
|
Signed-off-by: John Johansen <jjohansen@suse.de>
|
|
|
|
---
|
|
fs/ecryptfs/inode.c | 4 +++-
|
|
fs/namei.c | 6 ++++--
|
|
fs/nfsd/vfs.c | 12 ++++++++----
|
|
include/linux/fs.h | 2 +-
|
|
4 files changed, 16 insertions(+), 8 deletions(-)
|
|
|
|
--- a/fs/ecryptfs/inode.c
|
|
+++ b/fs/ecryptfs/inode.c
|
|
@@ -443,6 +443,7 @@ static int ecryptfs_symlink(struct inode
|
|
{
|
|
int rc;
|
|
struct dentry *lower_dentry;
|
|
+ struct vfsmount *lower_mnt;
|
|
struct dentry *lower_dir_dentry;
|
|
umode_t mode;
|
|
char *encoded_symname;
|
|
@@ -451,6 +452,7 @@ static int ecryptfs_symlink(struct inode
|
|
|
|
lower_dentry = ecryptfs_dentry_to_lower(dentry);
|
|
dget(lower_dentry);
|
|
+ lower_mnt = ecryptfs_dentry_to_lower_mnt(dentry);
|
|
lower_dir_dentry = lock_parent(lower_dentry);
|
|
mode = S_IALLUGO;
|
|
encoded_symlen = ecryptfs_encode_filename(crypt_stat, symname,
|
|
@@ -460,7 +462,7 @@ static int ecryptfs_symlink(struct inode
|
|
rc = encoded_symlen;
|
|
goto out_lock;
|
|
}
|
|
- rc = vfs_symlink(lower_dir_dentry->d_inode, lower_dentry,
|
|
+ rc = vfs_symlink(lower_dir_dentry->d_inode, lower_dentry, lower_mnt,
|
|
encoded_symname, mode);
|
|
kfree(encoded_symname);
|
|
if (rc || !lower_dentry->d_inode)
|
|
--- a/fs/namei.c
|
|
+++ b/fs/namei.c
|
|
@@ -2411,7 +2411,8 @@ asmlinkage long sys_unlink(const char __
|
|
return do_unlinkat(AT_FDCWD, pathname);
|
|
}
|
|
|
|
-int vfs_symlink(struct inode *dir, struct dentry *dentry, const char *oldname, int mode)
|
|
+int vfs_symlink(struct inode *dir, struct dentry *dentry, struct vfsmount *mnt,
|
|
+ const char *oldname, int mode)
|
|
{
|
|
int error = may_create(dir, dentry, NULL);
|
|
|
|
@@ -2460,7 +2461,8 @@ asmlinkage long sys_symlinkat(const char
|
|
error = mnt_want_write(nd.path.mnt);
|
|
if (error)
|
|
goto out_dput;
|
|
- error = vfs_symlink(nd.path.dentry->d_inode, dentry, from, S_IALLUGO);
|
|
+ error = vfs_symlink(nd.path.dentry->d_inode, dentry, nd.path.mnt, from,
|
|
+ S_IALLUGO);
|
|
mnt_drop_write(nd.path.mnt);
|
|
out_dput:
|
|
dput(dentry);
|
|
--- a/fs/nfsd/vfs.c
|
|
+++ b/fs/nfsd/vfs.c
|
|
@@ -1518,6 +1518,7 @@ nfsd_symlink(struct svc_rqst *rqstp, str
|
|
struct iattr *iap)
|
|
{
|
|
struct dentry *dentry, *dnew;
|
|
+ struct svc_export *exp;
|
|
__be32 err, cerr;
|
|
int host_err;
|
|
umode_t mode;
|
|
@@ -1548,6 +1549,7 @@ nfsd_symlink(struct svc_rqst *rqstp, str
|
|
if (host_err)
|
|
goto out_nfserr;
|
|
|
|
+ exp = fhp->fh_export;
|
|
if (unlikely(path[plen] != 0)) {
|
|
char *path_alloced = kmalloc(plen+1, GFP_KERNEL);
|
|
if (path_alloced == NULL)
|
|
@@ -1555,14 +1557,16 @@ nfsd_symlink(struct svc_rqst *rqstp, str
|
|
else {
|
|
strncpy(path_alloced, path, plen);
|
|
path_alloced[plen] = 0;
|
|
- host_err = vfs_symlink(dentry->d_inode, dnew, path_alloced, mode);
|
|
+ host_err = vfs_symlink(dentry->d_inode, dnew,
|
|
+ exp->ex_path.mnt, path_alloced, mode);
|
|
kfree(path_alloced);
|
|
}
|
|
} else
|
|
- host_err = vfs_symlink(dentry->d_inode, dnew, path, mode);
|
|
+ host_err = vfs_symlink(dentry->d_inode, dnew, exp->ex_path.mnt,
|
|
+ path, mode);
|
|
|
|
if (!host_err) {
|
|
- if (EX_ISSYNC(fhp->fh_export))
|
|
+ if (EX_ISSYNC(exp))
|
|
host_err = nfsd_sync_dir(dentry);
|
|
}
|
|
err = nfserrno(host_err);
|
|
@@ -1570,7 +1574,7 @@ nfsd_symlink(struct svc_rqst *rqstp, str
|
|
|
|
mnt_drop_write(fhp->fh_export->ex_path.mnt);
|
|
|
|
- cerr = fh_compose(resfhp, fhp->fh_export, dnew, fhp);
|
|
+ cerr = fh_compose(resfhp, exp, dnew, fhp);
|
|
dput(dnew);
|
|
if (err==0) err = cerr;
|
|
out:
|
|
--- a/include/linux/fs.h
|
|
+++ b/include/linux/fs.h
|
|
@@ -1125,7 +1125,7 @@ extern int vfs_permission(struct nameida
|
|
extern int vfs_create(struct inode *, struct dentry *, int, struct nameidata *);
|
|
extern int vfs_mkdir(struct inode *, struct dentry *, struct vfsmount *, int);
|
|
extern int vfs_mknod(struct inode *, struct dentry *, struct vfsmount *, int, dev_t);
|
|
-extern int vfs_symlink(struct inode *, struct dentry *, const char *, int);
|
|
+extern int vfs_symlink(struct inode *, struct dentry *, struct vfsmount *, const char *, int);
|
|
extern int vfs_link(struct dentry *, struct inode *, struct dentry *);
|
|
extern int vfs_rmdir(struct inode *, struct dentry *);
|
|
extern int vfs_unlink(struct inode *, struct dentry *);
|