mirrors/dnscrypt-proxy
1
0
Fork 0
mirror of https://github.com/DNSCrypt/dnscrypt-proxy.git synced 2025-03-04 02:14:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

Add some missing error checks (#2420)

Browse source 
I found these with the 'errcheck' tool (via 'golangci-lint').

I aimed to apply reasonable judgement when deciding which errors
actually need handling, and how to handle them.
This commit is contained in:
Carlo Teubner 2023-06-24 21:23:12 +01:00 • committed by GitHub
parent cef4b041d7
commit b46775ae0c
Failed to generate hash of commit
3 changed files with 16 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
dnscrypt-proxy/config.go
View file

@ -861,7 +861,9 @@ func (config *Config) loadSources(proxy *Proxy) error {
} }
proxy.registeredServers = append(proxy.registeredServers, RegisteredServer{name: serverName, stamp: stamp}) proxy.registeredServers = append(proxy.registeredServers, RegisteredServer{name: serverName, stamp: stamp})
} }
proxy.updateRegisteredServers() if err := proxy.updateRegisteredServers(); err != nil {
return err
}
rs1 := proxy.registeredServers rs1 := proxy.registeredServers
rs2 := proxy.serversInfo.registeredServers rs2 := proxy.serversInfo.registeredServers
rand.Shuffle(len(rs1), func(i, j int) { rand.Shuffle(len(rs1), func(i, j int) {

9
dnscrypt-proxy/main.go
View file

@ -27,8 +27,11 @@ type App struct {
} }
func main() { func main() {
TimezoneSetup() tzErr := TimezoneSetup()
dlog.Init("dnscrypt-proxy", dlog.SeverityNotice, "DAEMON") dlog.Init("dnscrypt-proxy", dlog.SeverityNotice, "DAEMON")
if tzErr != nil {
dlog.Errorf("Timezone setup failed: %v", tzErr)
}
runtime.MemProfileRate = 0 runtime.MemProfileRate = 0
seed := make([]byte, 8) seed := make([]byte, 8)
@ -141,7 +144,9 @@ func (app *App) AppMain() {
} }
func (app *App) Stop(service service.Service) error { func (app *App) Stop(service service.Service) error {
PidFileRemove() if err := PidFileRemove(); err != nil {
dlog.Warnf("Failed to remove the PID file: %v", err)
}
dlog.Notice("Stopped.") dlog.Notice("Stopped.")
return nil return nil
} }

8
dnscrypt-proxy/serversInfo.go
View file

@ -615,7 +615,9 @@ func dohTestPacket(msgID uint16) []byte {
msg.SetEdns0(uint16(MaxDNSPacketSize), false) msg.SetEdns0(uint16(MaxDNSPacketSize), false)
ext := new(dns.EDNS0_PADDING) ext := new(dns.EDNS0_PADDING)
ext.Padding = make([]byte, 16) ext.Padding = make([]byte, 16)
crypto_rand.Read(ext.Padding) if _, err := crypto_rand.Read(ext.Padding); err != nil {
dlog.Fatal(err)
}
edns0 := msg.IsEdns0() edns0 := msg.IsEdns0()
edns0.Option = append(edns0.Option, ext) edns0.Option = append(edns0.Option, ext)
body, err := msg.Pack() body, err := msg.Pack()
@ -638,7 +640,9 @@ func dohNXTestPacket(msgID uint16) []byte {
msg.SetEdns0(uint16(MaxDNSPacketSize), false) msg.SetEdns0(uint16(MaxDNSPacketSize), false)
ext := new(dns.EDNS0_PADDING) ext := new(dns.EDNS0_PADDING)
ext.Padding = make([]byte, 16) ext.Padding = make([]byte, 16)
crypto_rand.Read(ext.Padding) if _, err := crypto_rand.Read(ext.Padding); err != nil {
dlog.Fatal(err)
}
edns0 := msg.IsEdns0() edns0 := msg.IsEdns0()
edns0.Option = append(edns0.Option, ext) edns0.Option = append(edns0.Option, ext)
body, err := msg.Pack() body, err := msg.Pack()