mirrors/opensnitch
1
0
Fork 0
mirror of https://github.com/evilsocket/opensnitch.git synced 2025-03-04 08:34:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ui: fixed acting on selected rows

Browse source 
When selecting rows with CTRL we were not copying/deleting rules
correctly.

Closes #1245
This commit is contained in:
Gustavo Iñiguez Goia 2025-01-04 00:44:34 +01:00
parent 422a2dd82d
commit 337b81a89b
Failed to generate hash of commit
2 changed files with 17 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
ui/opensnitch/customwidgets/generictableview.py
View file

@ -337,17 +337,20 @@ class GenericTableView(QTableView):
self.selectionModel().clearCurrentIndex()
def copySelection(self):
selection = self.selectedIndexes()
if selection:
rows = sorted(index.row() for index in selection)
rowcount = rows[-1] - rows[0] + 1
table = self.model().copySelectedRows(
selection[0].row() + self.vScrollBar.value() - 1,
rowcount)
return table
model = self.selectionModel()
curModel = self.model()
selection = model.selectedRows()
if not selection:
return None
rows = []
for idx in selection:
row = []
for col in range(0, curModel.columnCount()):
row.append(curModel.index(idx.row(), col).data())
rows.append(row)
return rows
def getCurrentIndex(self):
return self.selectionModel().currentIndex().internalId()

9
ui/opensnitch/dialogs/stats.py
View file

@ -1066,6 +1066,8 @@ class StatsDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
cur_idx = self.tabWidget.currentIndex()
if self.tabWidget.currentIndex() == self.TAB_RULES and self.fwTable.isVisible():
cur_idx = self.TAB_FIREWALL
elif self.tabWidget.currentIndex() == self.TAB_RULES and not self.fwTable.isVisible():
cur_idx = self.TAB_RULES
selection = self.TABLES[cur_idx]['view'].copySelection()
if selection:
stream = io.StringIO()
@ -1564,10 +1566,9 @@ class StatsDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
self._notifications_sent[nid] = noti
elif cur_idx == self.TAB_RULES and self.rulesTable.isVisible():
selection = self.TABLES[cur_idx]['view'].copySelection()
for row in selection:
name = row[self.COL_R_NAME]
node = row[self.COL_R_NODE]
for idx in selection:
name = model.index(idx.row(), self.COL_R_NAME).data()
node = model.index(idx.row(), self.COL_R_NODE).data()
self._del_rule(name, node)
elif cur_idx == self.TAB_RULES and self.alertsTable.isVisible():