mirrors/opensnitch
1
0
Fork 0
mirror of https://github.com/evilsocket/opensnitch.git synced 2025-03-04 08:34:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ui,stats: improved rules deletion

Browse source 
When selecting rules with CTRL+A it was not deleting all the rules.
Besides rules with the name empty was sent to the daemon.

Related: #1037
This commit is contained in:
Gustavo Iñiguez Goia 2023-10-13 23:51:37 +02:00
parent 4493c86bc3
commit 5fd7da8ef5
Failed to generate hash of commit
1 changed files with 7 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
ui/opensnitch/dialogs/stats.py
View file

@ -805,6 +805,9 @@ class StatsDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
return ret1 and ret2
def _del_rule(self, rule_name, node_addr):
if rule_name == None or node_addr == None:
print("_del_rule() invalid parameters")
return
nid, noti = self._nodes.delete_rule(rule_name, node_addr, self._notification_callback)
if nid == None:
return
@ -1236,9 +1239,10 @@ class StatsDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
self._notifications_sent[nid] = noti
elif cur_idx == self.TAB_RULES and not self.fwTable.isVisible():
for idx in selection:
name = model.index(idx.row(), self.COL_R_NAME).data()
node = model.index(idx.row(), self.COL_R_NODE).data()
selection = self.TABLES[cur_idx]['view'].copySelection()
for row in selection:
name = row[self.COL_R_NAME]
node = row[self.COL_R_NODE]
self._del_rule(name, node)
elif cur_idx == self.TAB_HOSTS or cur_idx == self.TAB_PROCS or cur_idx == self.TAB_ADDRS or \
cur_idx == self.TAB_USERS or cur_idx == self.TAB_PORTS: