From 97139ecc6be2a9bd0dc18766bcae5c143deec26d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gustavo=20I=C3=B1iguez=20Goia?= <gooffy1@gmail.com>
Date: Fri, 26 Jun 2020 22:47:44 +0200
Subject: [PATCH] UI: shorten default rules name

Default rules name can be extremely long when the rule is of type list.
It still will be in some cases, but should work in most cases.

closes #37
---
 ui/opensnitch/dialogs/prompt.py | 16 +++++++++++++++-
 1 file changed, 15 insertions(+), 1 deletion(-)

diff --git a/ui/opensnitch/dialogs/prompt.py b/ui/opensnitch/dialogs/prompt.py
index 4094d8ca..fdcfe9af 100644
--- a/ui/opensnitch/dialogs/prompt.py
+++ b/ui/opensnitch/dialogs/prompt.py
@@ -361,6 +361,16 @@ class PromptDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
         self._default_action = self.ACTION_ALLOW
         self._send_rule()
 
+    def _get_rule_name(self):
+        rule_temp_name = slugify("%s %s" % (self._rule.action, self._rule.duration))
+        if self._ischeckAdvanceded:
+            rule_temp_name = "%s-list" % rule_temp_name
+        else:
+            rule_temp_name = "%s-simple" % rule_temp_name
+        rule_temp_name = slugify("%s %s" % (rule_temp_name, self._rule.operator.data))
+
+        return rule_temp_name
+
     def _send_rule(self):
         self._cfg.setSettings("promptDialog/geometry", self.saveGeometry())
         self._rule = ui_pb2.Rule(name="user.choice")
@@ -373,17 +383,21 @@ class PromptDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
         what_idx = self.whatCombo.currentIndex()
         self._rule.operator.type, self._rule.operator.operand, self._rule.operator.data = self._get_combo_operator(self.whatCombo, what_idx)
 
+        rule_temp_name = self._get_rule_name()
+
         # TODO: move to a method
         data=[]
         if self._ischeckAdvanceded and self.checkDstIP.isChecked() and self.whatCombo.itemData(what_idx) != "dst_ip":
             _type, _operand, _data = self._get_combo_operator(self.whatIPCombo, self.whatIPCombo.currentIndex())
             data.append({"type": _type, "operand": _operand, "data": _data})
+            rule_temp_name = slugify("%s %s" % (rule_temp_name, _data))
 
         if self._ischeckAdvanceded and self.checkDstPort.isChecked() and self.whatCombo.itemData(what_idx) != "dst_port":
             data.append({"type": "simple", "operand": "dest.port", "data": str(self._con.dst_port)})
 
         if self._ischeckAdvanceded and self.checkUserID.isChecked() and self.whatCombo.itemData(what_idx) != "user_id":
             data.append({"type": "simple", "operand": "user.id", "data": str(self._con.user_id)})
+            rule_temp_name = slugify("%s %s" % (rule_temp_name, str(self._con.user_id)))
 
         if self._ischeckAdvanceded:
             data.append({"type": self._rule.operator.type, "operand": self._rule.operator.operand, "data": self._rule.operator.data})
@@ -391,7 +405,7 @@ class PromptDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
             self._rule.operator.type = "list"
             self._rule.operator.operand = ""
 
-        self._rule.name = slugify("%s %s %s" % (self._rule.action, self._rule.operator.type, self._rule.operator.data))
+        self._rule.name = rule_temp_name
 
         self.hide()
         if self._ischeckAdvanceded: