From a9215eb2477bc27f159d17e262ebc7b837a94f1e Mon Sep 17 00:00:00 2001 From: martynhare Date: Sat, 8 Sep 2018 18:39:35 +0100 Subject: [PATCH] Applying Northern-Lights recommendation of handling generic exceptions via except --- ui/opensnitch/dialogs/stats.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ui/opensnitch/dialogs/stats.py b/ui/opensnitch/dialogs/stats.py index 0ac63f3c..64c8ae3f 100644 --- a/ui/opensnitch/dialogs/stats.py +++ b/ui/opensnitch/dialogs/stats.py @@ -176,7 +176,6 @@ class StatsDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]): @QtCore.pyqtSlot() def _on_update_triggered(self): - pw_name = "(UID error)" if self.daemon_connected: self._status_label.setText("running") self._status_label.setStyleSheet('color: green') @@ -206,6 +205,8 @@ class StatsDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]): pw_name = pwd.getpwuid(int(uid)).pw_name except KeyError: pw_name = "(UID error)" + except Exception: + pw_name = "error" finally: by_users["%s (%s)" % (pw_name, uid)] = hits else: