mirrors/opensnitch
1
0
Fork 0
mirror of https://github.com/evilsocket/opensnitch.git synced 2025-03-04 08:34:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ui,fw: fixed restoring policies when disabling fw

Browse source 
When disabling the fw, we change the default input and output policy to
Accept, not to block connections.

Due to a problem reloading the fw in the daemon, the policy was not
changed as expected.

This problem must be fixed in the daemon, but for the time being,
sending two configuration changes solves the issue (one for changing the
policy, and another one for disabling the fw).

Closes: #1225
This commit is contained in:
Gustavo Iñiguez Goia 2024-12-13 21:11:50 +01:00
parent b1e279fb6b
commit d825f1e9b0
Failed to generate hash of commit
1 changed files with 54 additions and 22 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

76
ui/opensnitch/dialogs/firewall.py
View file

@ -325,33 +325,65 @@ class FirewallDialog(QtWidgets.QDialog, uic.loadUiType(DIALOG_UI_PATH)[0]):
return False return False
def enable_fw(self, enable): def enable_fw(self, enable):
self._disable_widgets(not enable) try:
if enable: self._disable_widgets(not enable)
self._set_status_message(QC.translate("firewall", "Enabling firewall...")) if enable:
else: self._set_status_message(QC.translate("firewall", "Enabling firewall..."))
self._set_status_message(QC.translate("firewall", "Disabling firewall...")) else:
self._set_status_message(QC.translate("firewall", "Disabling firewall..."))
# if previous input policy was DROP, when disabling the firewall it
# must be ACCEPT to allow output traffic.
if not enable and self.comboInput.currentIndex() == self.POLICY_DROP:
self.comboInput.blockSignals(True)
self.comboInput.setCurrentIndex(self.POLICY_ACCEPT)
self.comboInput.blockSignals(False)
for addr in self._nodes.get():
json_profile = json.dumps(FwProfiles.ProfileAcceptInput.value)
ok, err = self._fw.apply_profile(addr, json_profile)
if not ok:
self._set_status_error(
QC.translate("firewall", "Error applying INPUT ACCEPT profile: {0}".format(err))
)
return
if not enable and self.comboOutput.currentIndex() == self.POLICY_DROP:
self.comboOutput.blockSignals(True)
self.comboOutput.setCurrentIndex(self.POLICY_ACCEPT)
self.comboOutput.blockSignals(False)
for addr in self._nodes.get():
json_profile = json.dumps(FwProfiles.ProfileAcceptOutput.value)
ok, err = self._fw.apply_profile(addr, json_profile)
if not ok:
self._set_status_error(
QC.translate("firewall", "Error applying OUTPUT ACCEPT profile: {0}".format(err))
)
return
# if previous input policy was DROP, when disabling the firewall it
# must be ACCEPT to allow output traffic.
if not enable and self.comboInput.currentIndex() == self.POLICY_DROP:
self.comboInput.blockSignals(True)
self.comboInput.setCurrentIndex(self.POLICY_ACCEPT)
self.comboInput.blockSignals(False)
for addr in self._nodes.get(): for addr in self._nodes.get():
json_profile = json.dumps(FwProfiles.ProfileAcceptInput.value) # FIXME:
ok, err = self._fw.apply_profile(addr, json_profile) # Due to how the daemon reacts to events when the fw configuration
if not ok: # is modified, changing the policy + disabling the fw doesn't work
print("[firewall] Error applying INPUT ACCEPT profile: {0}".format(err)) # as expected.
# The daemon detects that the fw is disabled, and it never changes
# the policy.
# As a workaround to this problem, we send 2 fw changes:
# - one for changing the policy
# - another one for disabling the fw
for addr in self._nodes.get(): fwcfg = self._nodes.get_node(addr)['firewall']
fwcfg = self._nodes.get_node(addr)['firewall'] self.send_notification(addr, fwcfg)
fwcfg.Enabled = True if enable else False time.sleep(0.5)
self.send_notification(addr, fwcfg) fwcfg.Enabled = True if enable else False
self.send_notification(addr, fwcfg)
self.lblStatusIcon.setEnabled(enable) self.lblStatusIcon.setEnabled(enable)
self.policiesBox.setEnabled(enable) self.policiesBox.setEnabled(enable)
time.sleep(0.5) time.sleep(0.5)
except Exception as e:
QC.translate("firewall", "Error: {0}".format(e))
def load_rule(self, addr, uuid): def load_rule(self, addr, uuid):
self._fwrule_dialog.load(addr, uuid) self._fwrule_dialog.load(addr, uuid)