mirrors/opensnitch
1
0
Fork 0
mirror of https://github.com/evilsocket/opensnitch.git synced 2025-03-04 08:34:40 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions 1

ui,popups: strip non-printable characters from labels

Browse source 
Commands with non-printable characters were misaligning the labels.

Now these characters are exclude from the labels, and texts are
displayed as a single line.
This commit is contained in:
Gustavo Iñiguez Goia 2024-12-18 00:52:10 +01:00
parent 01e1341770
commit eab75b8a48
Failed to generate hash of commit
1 changed files with 25 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
ui/opensnitch/dialogs/prompt/_utils.py
View file

@ -6,10 +6,13 @@ from PyQt5.QtCore import QCoreApplication as QC
from opensnitch.config import Config from opensnitch.config import Config
from opensnitch.dialogs.prompt import _constants from opensnitch.dialogs.prompt import _constants
def set_elide_text(widget, text, max_size=132): def truncate_text(text, max_size=64):
if len(text) > max_size: if len(text) > max_size:
text = text[:max_size] + "..." text = text[:max_size] + "..."
return text
def set_elide_text(widget, text, max_size=64):
text = truncate_text(text, max_size)
widget.setText(text) widget.setText(text)
def get_rule_name(rule, is_list): def get_rule_name(rule, is_list):
@ -28,6 +31,8 @@ def get_popup_message(is_local, node, app_name, con):
the pop-up dialog. Example: the pop-up dialog. Example:
curl is connecting to www.opensnitch.io on TCP port 443 curl is connecting to www.opensnitch.io on TCP port 443
""" """
app_name = truncate_text(app_name)
message = "<b>%s</b>" % app_name message = "<b>%s</b>" % app_name
if not is_local: if not is_local:
message = QC.translate("popups", "<b>Remote</b> process %s running on <b>%s</b>") % ( \ message = QC.translate("popups", "<b>Remote</b> process %s running on <b>%s</b>") % ( \
@ -72,17 +77,29 @@ def set_app_path(appPathLabel, app_name, app_args, con):
appPathLabel.setVisible(False) appPathLabel.setVisible(False)
appPathLabel.setText("") appPathLabel.setText("")
appPathLabel.setText(
"".join(
filter(str.isprintable, appPathLabel.text())
)
)
def set_app_args(argsLabel, app_name, app_args): def set_app_args(argsLabel, app_name, app_args):
# if the app name and the args are the same, there's no need to display # if the app name and the args are the same, there's no need to display
# the args label (amule for example) # the args label (amule for example)
if app_name.lower() != app_args: if app_name.lower() != app_args:
argsLabel.setVisible(True) argsLabel.setVisible(True)
set_elide_text(argsLabel, app_args) set_elide_text(argsLabel, app_args, 256)
argsLabel.setToolTip(app_args) argsLabel.setToolTip(app_args)
else: else:
argsLabel.setVisible(False) argsLabel.setVisible(False)
argsLabel.setText("") argsLabel.setText("")
argsLabel.setText(
"".join(
filter(str.isprintable, argsLabel.text())
)
)
def set_app_description(appDescriptionLabel, description): def set_app_description(appDescriptionLabel, description):
if description != None and description != "": if description != None and description != "":
appDescriptionLabel.setVisible(True) appDescriptionLabel.setVisible(True)
@ -94,6 +111,12 @@ def set_app_description(appDescriptionLabel, description):
appDescriptionLabel.setFixedHeight(0) appDescriptionLabel.setFixedHeight(0)
appDescriptionLabel.setText("") appDescriptionLabel.setText("")
appDescriptionLabel.setText(
"".join(
filter(str.isprintable, appDescriptionLabel.text())
)
)
def get_duration(duration_idx): def get_duration(duration_idx):
if duration_idx == 0: if duration_idx == 0:
return Config.DURATION_ONCE return Config.DURATION_ONCE