mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2024-11-11 04:54:14 +01:00
Code Issues Packages Projects Releases Wiki Activity

container_at_stacked: skip titles when zero pixels

Browse Source 
It is possible to make the title bars have a zero pixel height while
stacked, by using a blank font and no padding. This causes a division by
zero when attempting to calculate the child index in
container_at_stacked, which then results in a segfault when attempting
to access the child at that bad index (INT_MIN). This just skips the
check to see if the cursor is over a title bar of a child of a stacked
container when the title bar height is zero since there will be no title
bars.
This commit is contained in:
Brian Ashworth 2019-02-08 22:29:35 -05:00 committed by Drew DeVault
parent 4339ba6424
commit 243d5a3a43
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
sway/tree/container.c
View File

@ -251,10 +251,12 @@ static struct sway_container *container_at_stacked(struct sway_node *parent,
// Title bars // Title bars
int title_height = container_titlebar_height(); int title_height = container_titlebar_height();
int child_index = (ly - box.y) / title_height; if (title_height > 0) {
if (child_index < children->length) { int child_index = (ly - box.y) / title_height;
struct sway_container *child = children->items[child_index]; if (child_index < children->length) {
return child; struct sway_container *child = children->items[child_index];
return child;
}
} }
// Surfaces // Surfaces