mirrors/sway
1
0
Fork 0
mirror of https://github.com/swaywm/sway.git synced 2024-12-28 07:56:31 +01:00
Code Issues Projects Releases Packages Wiki Activity

properly hide top border inside tabbed/stacked

Browse source 
When titlebar is hidden, top border of the topmost view inside
tabbed/stacked container will not be drawn. This is changed in layout.c

On the other hand, top border should be drawn sometimes, for example
when titlebar is hidden on a view that is not the topmost inside
tabbed/stacked container. This is changed in border.c
This commit is contained in:
D.B 2016-07-30 15:12:34 +02:00
parent 3f83968d30
commit 8d0048c8d5
3 changed files with 20 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
include/border.h
View file

@ -20,5 +20,6 @@ void render_view_borders(wlc_handle view);
void update_view_border(swayc_t *view); void update_view_border(swayc_t *view);
void map_update_view_border(swayc_t *view, void *data); void map_update_view_border(swayc_t *view, void *data);
int get_font_text_height(const char *font); int get_font_text_height(const char *font);
bool should_hide_top_border(swayc_t *con, double y);
#endif #endif

20
sway/border.c
View file

@ -332,10 +332,12 @@ void update_view_border(swayc_t *view) {
} }
}; };
cr = create_border_buffer(view, g, &surface); cr = create_border_buffer(view, g, &surface);
bool render_top = !should_hide_top_border(view, view->y);
if (view == focused) { if (view == focused) {
render_borders(view, cr, &config->border_colors.focused, false); render_borders(view, cr, &config->border_colors.focused, render_top);
} else { } else {
render_borders(view, cr, &config->border_colors.focused_inactive, false); render_borders(view, cr, &config->border_colors.focused_inactive, render_top);
} }
// generate container titles // generate container titles
@ -418,3 +420,17 @@ void render_view_borders(wlc_handle view) {
wlc_pixels_write(WLC_RGBA8888, &c->border->geometry, c->border->buffer); wlc_pixels_write(WLC_RGBA8888, &c->border->geometry, c->border->buffer);
} }
} }
bool should_hide_top_border(swayc_t *con, double y) {
// returns true if container is child of tabbed/stacked layout and is
// sharing top border with tabbed titlebar
swayc_t *par = con->parent;
while (par->type != C_WORKSPACE) {
if (par->layout == L_TABBED || par->layout == L_STACKED) {
return con->y == y;
}
con = par;
par = par->parent;
}
return false;
}

2
sway/layout.c
View file

@ -587,7 +587,7 @@ void update_geometry(swayc_t *container) {
} }
if (config->hide_edge_borders == E_VERTICAL || config->hide_edge_borders == E_BOTH) { if (config->hide_edge_borders == E_VERTICAL || config->hide_edge_borders == E_BOTH) {
if (geometry.origin.y == workspace->y) { if (geometry.origin.y == workspace->y || should_hide_top_border(container, geometry.origin.y)) {
border_top = 0; border_top = 0;
} }