mirror of
https://github.com/swaywm/sway.git
synced 2024-12-28 07:56:31 +01:00
grimshot: fix branching on command exit status
The previous behavior was incorrect because `if` was checking the return status of the `[` command which was never going to be an error. `[` seems to only return an error if no args are provided. This was basically a useless use of `[` anyway since it was just meant as a straight interpretation of command exit, something that `if` can do itself. Compare: ```sh [ ]; echo ?=$? [ /bin/false ]; echo ?=$? if [ /bin/false ]; then echo this is the unintended bug; fi if /bin/false; then echo this will not be printed; fi ```
This commit is contained in:
parent
7f54495b5e
commit
8ffa3cf439
1 changed files with 2 additions and 4 deletions
|
@ -51,8 +51,7 @@ die() {
|
|||
|
||||
check() {
|
||||
COMMAND=$1
|
||||
command -v "$COMMAND" > /dev/null 2>&1
|
||||
if [ $? ]; then
|
||||
if command -v "$COMMAND" > /dev/null 2>&1; then
|
||||
RESULT="OK"
|
||||
else
|
||||
RESULT="NOT FOUND"
|
||||
|
@ -102,8 +101,7 @@ if [ "$ACTION" = "copy" ] ; then
|
|||
rm "$TMP"
|
||||
notifyOk "$WHAT copied to buffer"
|
||||
else
|
||||
takeScreenshot "$FILE" "$GEOM"
|
||||
if [ $? ]; then
|
||||
if takeScreenshot "$FILE" "$GEOM"; then
|
||||
TITLE="Screenshot of $SUBJECT"
|
||||
MESSAGE=$(basename "$FILE")
|
||||
notifyOk "$MESSAGE" "$TITLE"
|
||||
|
|
Loading…
Reference in a new issue