Merge pull request #2993 from xonsh/broke-sym

Broken symlinks

azure-pipelines.yml

@@ -21,17 +21,26 @@ jobs:
 
   # Conda Environment
   # Create and activate a Conda environment.
+  - task: CondaEnvironment@1
+    inputs:
+      packageSpecs: 'python=$(python.version) conda=4.5.11 pygments prompt_toolkit ply pytest pytest-timeout numpy psutil matplotlib flake8 coverage pyflakes pytest-cov pytest-flake8 codecov'
+      installOptions: '-c conda-forge/label/cf201901'
+      updateConda: false
+    condition: eq(variables['python.version'], '3.5')
+    displayName: 'Conda Environment (conda-forge/label/cf201901)'
   - task: CondaEnvironment@1
     inputs:
       packageSpecs: 'python=$(python.version) pygments prompt_toolkit ply pytest pytest-timeout numpy psutil matplotlib flake8 coverage pyflakes pytest-cov pytest-flake8 codecov'
       installOptions: '-c conda-forge'
       updateConda: false
+    condition: ne(variables['python.version'], '3.5')
+    displayName: 'Conda Environment (conda-forge)'
   - script: |
       pip install .
       xonsh run-tests.xsh --timeout=10 --junitxml=junit/test-results.xml
     displayName: 'Tests'
 
-# Publish build results
+  # Publish build results
   - task: PublishTestResults@2
     inputs:
       testResultsFiles: '**/test-*.xml'

news/broke-sym.rst

@@ -0,0 +1,23 @@
+**Added:**
+
+* <news item>
+
+**Changed:**
+
+* <news item>
+
+**Deprecated:**
+
+* <news item>
+
+**Removed:**
+
+* <news item>
+
+**Fixed:**
+
+* Made ``$PATH`` searching more robust to broken symlinks on Windows.
+
+**Security:**
+
+* <news item>

requirements-tests.txt

@@ -1,12 +1,12 @@
 ply
 py
 pytest
+flake8
+pyflakes<2.1.0,>=2.0.0
 pytest-flake8
 pytest-cov
 pytest-timeout
 prompt-toolkit
 pygments>=2.2
 codecov
-flake8
-pyflakes
 coverage

xonsh/tools.py

@@ -790,7 +790,11 @@ def _executables_in_windows(path):
                     yield fname
     else:
         for x in scandir(path):
-            if x.is_file():
+            try:
+                is_file = x.is_file()
+            except OSError:
+                continue
+            if is_file:
                 fname = x.name
             else:
                 continue