fix(xpip): never add sudo, append --user instead (#4879)

news/xpip_perms.rst

@@ -0,0 +1,24 @@
+**Added:**
+
+* <news item>
+
+**Changed:**
+
+* <news item>
+
+**Deprecated:**
+
+* <news item>
+
+**Removed:**
+
+* <news item>
+
+**Fixed:**
+
+* <news item>
+
+**Security:**
+
+* ``xpip`` will never add ``sudo`` under any circumstances and will instead append ``--user`` as needed
+

xonsh/aliases.py

@@ -815,7 +815,7 @@ def detect_xpip_alias():
             # XXX: Does windows have an installation mode that requires UAC?
             return basecmd
         elif not os.access(os.path.dirname(sys.executable), os.W_OK):
-            return ["sudo"] + basecmd
+            return basecmd.extend(["--user"])
         else:
             return basecmd
     except Exception: