From 5ee10f1fff97d2cd3695948d07484aaf84790410 Mon Sep 17 00:00:00 2001 From: Jakub Nowak Date: Tue, 18 Sep 2018 21:54:52 +0200 Subject: [PATCH 1/3] Allow 'off' as falsy value --- xonsh/tools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/xonsh/tools.py b/xonsh/tools.py index 2e8fa41d4..f60f519e1 100644 --- a/xonsh/tools.py +++ b/xonsh/tools.py @@ -1185,7 +1185,7 @@ def logfile_opt_to_str(x): _FALSES = LazyObject( - lambda: frozenset(["", "0", "n", "f", "no", "none", "false"]), globals(), "_FALSES" + lambda: frozenset(["", "0", "n", "f", "no", "none", "false", "off"]), globals(), "_FALSES" ) From 83f2d89bb095f1faee14a8fa896ba41ff3084610 Mon Sep 17 00:00:00 2001 From: Jakub Nowak Date: Tue, 18 Sep 2018 23:08:18 +0200 Subject: [PATCH 2/3] Add entry in changelog --- news/allow_off_as_falsy.rst | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 news/allow_off_as_falsy.rst diff --git a/news/allow_off_as_falsy.rst b/news/allow_off_as_falsy.rst new file mode 100644 index 000000000..38e528526 --- /dev/null +++ b/news/allow_off_as_falsy.rst @@ -0,0 +1,13 @@ +**Added:** None + +* 'off' can be passed as falsy value to all flags accepting boolean argument. + +**Changed:** None + +**Deprecated:** None + +**Removed:** None + +**Fixed:** None + +**Security:** None From b945ad5454d1a8662c6a338ee577792906dd2849 Mon Sep 17 00:00:00 2001 From: Jakub Nowak Date: Fri, 21 Sep 2018 06:30:58 +0200 Subject: [PATCH 3/3] Remove None from rst --- news/allow_off_as_falsy.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/news/allow_off_as_falsy.rst b/news/allow_off_as_falsy.rst index 38e528526..821ebb09a 100644 --- a/news/allow_off_as_falsy.rst +++ b/news/allow_off_as_falsy.rst @@ -1,4 +1,4 @@ -**Added:** None +**Added:** * 'off' can be passed as falsy value to all flags accepting boolean argument.