There is really no reason to implement file_exists on our own.

This commit is contained in:
Sebastian Ramacher 2012-03-19 17:03:27 +01:00
parent c9de38d960
commit 2475c371fd
4 changed files with 1 additions and 28 deletions

View file

@ -209,7 +209,7 @@ zathura_document_open(zathura_t* zathura, const char* path, const char* password
return NULL; return NULL;
} }
if (file_exists(path) == false) { if (g_file_test(path, G_FILE_TEST_EXISTS) == FALSE) {
girara_error("File '%s' does not exist", path); girara_error("File '%s' does not exist", path);
return NULL; return NULL;
} }

View file

@ -4,10 +4,6 @@
#include "../utils.h" #include "../utils.h"
START_TEST(test_file_exists_null) {
fail_unless(file_exists(NULL) == false, NULL);
} END_TEST
START_TEST(test_file_get_extension_null) { START_TEST(test_file_get_extension_null) {
fail_unless(file_get_extension(NULL) == NULL, NULL); fail_unless(file_get_extension(NULL) == NULL, NULL);
} END_TEST } END_TEST
@ -34,11 +30,6 @@ Suite* suite_utils()
TCase* tcase = NULL; TCase* tcase = NULL;
Suite* suite = suite_create("Utils"); Suite* suite = suite_create("Utils");
/* file exists */
tcase = tcase_create("file_exists");
tcase_add_test(tcase, test_file_exists_null);
suite_add_tcase(suite, tcase);
/* file exists */ /* file exists */
tcase = tcase_create("file_get_extension"); tcase = tcase_create("file_get_extension");
tcase_add_test(tcase, test_file_get_extension_null); tcase_add_test(tcase, test_file_get_extension_null);

10
utils.c
View file

@ -17,16 +17,6 @@
#define BLOCK_SIZE 64 #define BLOCK_SIZE 64
bool
file_exists(const char* path)
{
if (!access(path, F_OK)) {
return true;
} else {
return false;
}
}
const char* const char*
file_get_extension(const char* path) file_get_extension(const char* path)
{ {

View file

@ -17,14 +17,6 @@ typedef struct page_offset_s
int y; int y;
} page_offset_t; } page_offset_t;
/**
* Checks if the given file exists
*
* @param path Path to the file
* @return true if the file exists, otherwise false
*/
bool file_exists(const char* path);
/** /**
* Returns the file extension of a path * Returns the file extension of a path
* *